system: overrides banner related to #8206 #8216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fichtner We could further split the status design into |
|
Sure, do you want a ticket instead? |
|
Yes please, I'll use this branch as a base |
Introduces the isBanner property, which explicitly defines the message as a banner, which doesn't necessarily have a relation to the persistent property. While here, update the UI to remove cursor events when the message doesn't have a location set.
fichtner
force-pushed
the
override_banner
branch
from
3c406c1 to
3f60a31
Compare
|
Merged, thanks!? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.