Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure urljoin behaviour is correct #13

Merged
merged 2 commits into from
Jun 18, 2022
Merged

Ensure urljoin behaviour is correct #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bec4db6
Ensure urljoin behaviour is correct
davfsa Jun 15, 2022
e5c81c9
Run black on files
davfsa Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mkdocs_gen_files/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ def on_page_content(self, html, page: Page, config: Config, files: Files):
if src_path in self._edit_paths:
path = self._edit_paths.pop(src_path)
if repo_url and edit_uri:
# Ensure urljoin behavior is correct
if not edit_uri.startswith(("?", "#")) and not repo_url.endswith("/"):
repo_url += "/"

page.edit_url = path and urllib.parse.urljoin(
urllib.parse.urljoin(repo_url, edit_uri), path
)
Expand Down