Fix implicit syntax collisions #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM @vladimirkl thanks for the PR! Do you know if it applies to any other macros? or other syntax classes? |
|
btw does this change only apply to cats branch? if not could you update the PR toward master, we will cherry pick it back to cats on the next realease. |
|
I think that issue applies to every syntax class that subject as public field. Btw they are defined inconsistently - some are |
vladimirkl
force-pushed
the
bugfix/newtype-collision
branch
from
ac61eb7 to
f9b5c8c
Compare
vladimirkl
changed the title
|
Thanks @vladimirkl ! |
|
@julien-truffaut should I make a PR for cats branch with cherry pick? |
|
it would be great if you have time |
vladimirkl
added a commit
to vladimirkl/Monocle
that referenced
this pull request
Feb 20, 2019
julien-truffaut
pushed a commit
that referenced
this pull request
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a collision when we use something like scala-newtype and have
import monocle.macros.syntax.lens._in scope. A cause of collision isval value: AinGenApplyLensOpsso it conflicts with any.valuethat is defined via implicit syntax. The same issue was fixed in Cats code base - see typelevel/cats#2491 andtypelevel/cats#2614.
Proposed change can be considered as binary compatible - unless someone used
GenApplyLensOps.valuein code which is unlikely. We can probably do a bit more and replacetoGenApplyLensOpsandGenApplyLensOpswith single implicit class - as Scala looks to be not instantiating it for macro based syntax. But this change can break some code using GenApplyLensOps directly, so for now I'm just making.valueprivate and replace access to it in macro with pattern matching on tree.