Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #500

Merged
merged 6 commits into from
Jul 10, 2024
Merged

Cleanup #500

merged 6 commits into from
Jul 10, 2024

Conversation

janosg
Copy link
Member

@janosg janosg commented Jul 10, 2024

In this PR we shed some weight before we start the renaming and implementation of enhancement proposals.

Remove the dashboard

Remove the bokeh based dashboard. We have not promoted or used it for years and want to replace it with something more useful. Whether that is another dashboard, a tensorboard integration or a realtime convergence plot in a notebook is open.

Users who have used the dashboard can get similar functionality by using criterion_plot and params_plot on a log file inside a jupyter notebook.

Remove the simopt optimizers

We added the simopt optimizers for noisy objective function about a year ago but could not get our wrappers to solve simple optimization problems reliably and precisely. We therefore remove them again.

Users with noisy objective functions can use tranquilo, nag_bobyqa or nag_dfols instead.

Remove the derivative_plot

The derivative_plot visualizes the internal of Richardson extrapolation based numerical derivatives. Since we remove Richardson extrapolation, we need to remove the plot as well.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/estimagic/__init__.py 100.00% <ø> (+7.40%) ⬆️
src/estimagic/algorithms.py 100.00% <ø> (ø)
src/estimagic/config.py 71.42% <ø> (-5.05%) ⬇️
src/estimagic/estimation/estimate_ml.py 83.25% <ø> (ø)
src/estimagic/estimation/estimate_msm.py 89.43% <ø> (ø)
src/estimagic/logging/read_from_database.py 88.88% <ø> (ø)
src/estimagic/logging/read_log.py 95.72% <ø> (ø)
src/estimagic/optimization/nag_optimizers.py 82.65% <ø> (ø)
src/estimagic/optimization/optimize.py 92.26% <ø> (ø)
src/estimagic/optimization/scipy_optimizers.py 97.87% <ø> (ø)
... and 1 more

... and 2 files with indirect coverage changes

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@janosg janosg changed the title Remove dashboard. Cleanup Jul 10, 2024
@janosg janosg requested a review from timmens July 10, 2024 11:56
README.md Outdated Show resolved Hide resolved
docs/source/index.md Outdated Show resolved Hide resolved
Copy link
Member

@timmens timmens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just had a minor remark.

README.md Outdated Show resolved Hide resolved
docs/source/index.md Outdated Show resolved Hide resolved
@janosg janosg merged commit 9f878c1 into 0.5.0 Jul 10, 2024
15 checks passed
@janosg janosg deleted the remove-dashboard branch July 10, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants