Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-59515] Invokes with 0 callees are not unreachable in open analysis. #10067

Merged
merged 1 commit into from
Nov 12, 2024
Merged

[GR-59515] Invokes with 0 callees are not unreachable in open analysis. #10067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...src/com.oracle.graal.pointsto/src/com/oracle/graal/pointsto/results/StrengthenGraphs.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,8 +589,11 @@ private void handleInvoke(Invoke invoke, SimplifierTool tool) {

Collection<AnalysisMethod> callees = invokeFlow.getOriginalCallees();
if (callees.isEmpty()) {
unreachableInvoke(invoke, tool);
/* Invoke is unreachable, there is no point in improving any types further. */
if (isClosedTypeWorld) {
/* Invoke is unreachable, there is no point in improving any types further. */
unreachableInvoke(invoke, tool);
}
/* In open world we cannot make any assumptions about an invoke with 0 callees. */
return;
}
assert invokeFlow.isFlowEnabled() : "Disabled invoke should have no callees: " + invokeFlow + ", in method " + getQualifiedName(graph);
Expand Down