Proper getStackAccessControlContext implementation #3098
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello Lazar Mitrović, thanks for contributing a PR to our project! We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address lazar-mitrovic -(at)- msn -(dot)- com. You can sign it at that link. If you think you've already signed it, please comment below and we'll check. |
lazar-mitrovic
force-pushed
the
kerberos-fix
branch
from
6806d72 to
635e2ab
Compare
lazar-mitrovic
force-pushed
the
kerberos-fix
branch
from
635e2ab to
a900fbd
Compare
lazar-mitrovic
force-pushed
the
kerberos-fix
branch
3 times, most recently
from
aff275e to
a9dd37f
Compare
lazar-mitrovic
force-pushed
the
kerberos-fix
branch
2 times, most recently
from
43a0e80 to
5fd2a64
Compare
lazar-mitrovic
force-pushed
the
kerberos-fix
branch
2 times, most recently
from
b6380e1 to
a0104cf
Compare
christianwimmer
suggested changes
Mar 30, 2021
substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jdk/SecuritySubstitutions.java
Outdated
Show resolved
Hide resolved
substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jdk/SecuritySubstitutions.java
Show resolved
Hide resolved
substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jdk/SecuritySubstitutions.java
Outdated
Show resolved
Hide resolved
substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jdk/SecuritySubstitutions.java
Outdated
Show resolved
Hide resolved
substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jdk/StackTraceUtils.java
Outdated
Show resolved
Hide resolved
substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jdk/SecuritySubstitutions.java
Outdated
Show resolved
Hide resolved
lazar-mitrovic
force-pushed
the
kerberos-fix
branch
13 times, most recently
from
4728d6b to
1eb52dd
Compare
lazar-mitrovic
force-pushed
the
kerberos-fix
branch
4 times, most recently
from
fce53df to
2950140
Compare
|
@lazar-mitrovic thanks for the contribution, is there any update on the changes requested by the reviewer? |
I intend to work on this towards the end of this week (after all of the |
|
@lazar-mitrovic ok noted with thanks |
|
Are you getting any closer to merging this PR? |
lazar-mitrovic
force-pushed
the
kerberos-fix
branch
3 times, most recently
from
926bed2 to
c19c047
Compare
lazar-mitrovic
force-pushed
the
kerberos-fix
branch
from
c19c047 to
3645cfe
Compare
lazar-mitrovic
force-pushed
the
kerberos-fix
branch
3 times, most recently
from
e1e86d4 to
51b091e
Compare
lazar-mitrovic
force-pushed
the
kerberos-fix
branch
from
51b091e to
b3a913b
Compare
lazar-mitrovic
force-pushed
the
kerberos-fix
branch
6 times, most recently
from
b54a413 to
8649d2e
Compare
Fixed imports and warnings in SecuritySubstitutions Implemented PrivilegedStack and use FastThreadLocal Added missing getProtectionDomain method Recompute contexts from static initializers in runtime Disallow NO_CONTEXT_SINGLETON in executePrivileged Work around crash when ProcessPropertiesSupport is missing getExecutable impementation Provide dummy setters for substituted contexts as their values are constant.
lazar-mitrovic
force-pushed
the
kerberos-fix
branch
3 times, most recently
from
3ef984a to
dfadc2a
Compare
lazar-mitrovic
force-pushed
the
kerberos-fix
branch
from
dfadc2a to
2ad1de6
Compare
|
Closed in favor of: #3854 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apt updatein Github CI to avoid azure repository issues