Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for JFR ExecutionSample event. #4005

Conversation

jovanstevanovic
Copy link
Member

This PR is introducing the ExecutionSample event and adds one test for the thread repository.

Event signature:

@name("jdk.ExecutionSample")
@category({"Java Virtual Machine", "Profiling"})
@Label("Method Profiling Sample")
@description("Snapshot of a threads state")
class ExecutionSample extends jdk.jfr.Event {
@Label("Start Time")
@timestamp("TICKS")
long startTime;

@Label("Thread")
Thread sampledThread;

@Label("Stack Trace")
StackTrace stackTrace;

@Label("Thread State")
String state;
}

@oubidar-Abderrahim
Copy link
Member

Hi, @jovanstevanovic Thank you for contributing to GraalVM, could you please provide answers to the following questions?

  1. Is your PR complete and ready for review?
  2. Did you have a conversation about these changes with some team members and you would like for them to review this as they have more context? please mention them
  3. Does your changes rely on other changes made in a separate PR? if yes please link it to this one

@jovanstevanovic
Copy link
Member Author

Hi, @jovanstevanovic Thank you for contributing to GraalVM, could you please provide answers to the following questions?

1. Is your PR complete and ready for review?

2. Did you have a conversation about these changes with some team members and you would like for them to review this as they have more context? please mention them

3. Does your changes rely on other changes made in a separate PR? if yes please link it to this one

Hi, @oubidar-Abderrahim!

  1. It has one TODO left in the code because I was not sure how to do that.
  2. I talked with @christianhaeubl about these changes, and now, I'm waiting for his review.
  3. No, there are no other PRs linked to this one.

@jovanstevanovic jovanstevanovic force-pushed the jovanstevanovic/support-for-execution-sample-event branch from fc2a04b to 4dfe0d3 Compare January 12, 2022 11:37
Copy link
Member

@christianhaeubl christianhaeubl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor comments, everything else looks good.

@jovanstevanovic jovanstevanovic force-pushed the jovanstevanovic/support-for-execution-sample-event branch from 4dfe0d3 to b67604c Compare January 13, 2022 10:14
@jovanstevanovic jovanstevanovic force-pushed the jovanstevanovic/support-for-execution-sample-event branch from b67604c to 5b42e5a Compare January 13, 2022 10:27
@jovanstevanovic jovanstevanovic force-pushed the jovanstevanovic/support-for-execution-sample-event branch from 5b42e5a to 75dd482 Compare January 13, 2022 10:58
@graalvmbot graalvmbot merged commit d178088 into oracle:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants