[GR-36766] Darwin-aarch64: add support for MAP_JIT/pthread_jit_write_protect_np #4286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graalvmbot
force-pushed
the
github/burbanfo/svm-darwin-aarch64-jit
branch
from
92a634a to
d153c07
Compare
graalvmbot
force-pushed
the
github/burbanfo/svm-darwin-aarch64-jit
branch
6 times, most recently
from
f8bbc19 to
442fcd2
Compare
graalvmbot
force-pushed
the
github/burbanfo/svm-darwin-aarch64-jit
branch
from
442fcd2 to
0439106
Compare
|
The article mentions the JIT compiler support is intended for Apple Silicon, so I take it only applies to macOS_AArch64 as I don't think this would work on iOS_AAarch64? The changes of this PR are applied to |
|
Ha, good catch, thank you! I'll submit a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple added a new API to interact with runtime generated code, where an additional flag is required to be passed to
mmap(2)when executable memory is requested. Furthermorepthread_jit_write_protect_np(3)can be used to toggle the permission of that memory between RW and RX, on a thread-local basis.More details about this can be found here: https://developer.apple.com/documentation/apple-silicon/porting-just-in-time-compilers-to-apple-silicon