-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regression test for JDK 17 record annotations fix #4423
Conversation
@loicottet @olpaw Could you please have a look at this? I'm not sure what the best practise for native image tests is. Thanks! |
cba2167
to
8c09ff5
Compare
@jerboaa I believe the test should better be placed under https://github.com/oracle/graal/tree/master/substratevm/src/com.oracle.svm.test and I don't think it needs a special gate tag, i.e., it's OK to run it with the |
@zakkak is right. If we would add an @jerboaa please add a jdk17 specific test project |
8c09ff5
to
1d4a6dc
Compare
substratevm/src/com.oracle.svm.test/src/META-INF/native-image/reflect-config.json
Outdated
Show resolved
Hide resolved
1f3f802
to
f75b23b
Compare
This adds a JDK 17+ test project and adds a regression test for the fix described in issue oracle#3984
f75b23b
to
bbef970
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @jerboaa!
If somebody could help getting this integrated, I'd appreciate it. |
Gentle, ping. Could we get this integrated, please? Thank you! |
This flew under my radar, sorry. I have started the process to integrate this and it should be in soon. |
Thanks, @loicottet |
This adds a simple app using record annotations, for which a
native image gets generated. This is a regression test for
the fix described in issue #3984