Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][22.3] c++ compatible mangling support #5333

Merged
merged 7 commits into from
Nov 24, 2022

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Nov 1, 2022

Backports: #4950
Closes: #5274

Backport applies cleanly except for

private MethodPointer createExpandSignatureMethod(Executable member, boolean callerSensitiveAdapter) {
return expandSignatureMethods.computeIfAbsent(new SignatureKey(member, callerSensitiveAdapter), signatureKey -> {
ResolvedJavaMethod prototype = analysisAccess.getMetaAccess().lookupJavaMethod(callerSensitiveAdapter ? invokePrototypeForCallerSensitiveAdapter : invokePrototype).getWrapped();
return register(new ReflectionExpandSignatureMethod("invoke_" + signatureKey.uniqueShortName(), prototype, signatureKey.isStatic, signatureKey.argTypes, signatureKey.returnKind,
signatureKey.callerSensitiveAdapter));
});
}

due to dc932e5 not being part of 22.3

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 1, 2022
@zakkak zakkak requested a review from adinn November 1, 2022 10:02
Copy link
Collaborator

@adinn adinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@oubidar-Abderrahim
Copy link
Member

oubidar-Abderrahim commented Nov 7, 2022

@ezzarghili could you please review this PR, please let me know when the PR is ready to be mirrored to bitbucket. Thank you

@ezzarghili ezzarghili requested a review from olpaw November 14, 2022 11:21
@ezzarghili
Copy link
Member

@oubidar-Abderrahim please proceed with integration internally.

@jerboaa
Copy link
Collaborator

jerboaa commented Nov 22, 2022

Any update on this?

@ezzarghili
Copy link
Member

The PR is merged into our CPU branched internally, they will show up once they get mirrored to GitHub.

@graalvmbot graalvmbot merged commit e1fc27b into oracle:release/graal-vm/22.3 Nov 24, 2022
@zakkak zakkak deleted the backport-4950 branch November 25, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants