-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GR-4247] Initial Native image Replay bundle Support. #5460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of thoughts from my end. Seems a nice proposal!
If available, docker/podman should be used to run the image builder inside a well-defined container image. **This allows | ||
us to prevent the builder from using the network during image build**, thus guaranteeing that the image build result did | ||
not depend on some unknown (and therefore unreproducible) network state. Another advantage is that we can mount | ||
`input/classes` and `$GRAALVM_HOME` read-only into the container and only allow read-write access to the mounted `out` | ||
and `build` directories. This will prevent the application code that runs at image build time to mess with anything | ||
other than those directories. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even in such an environment, the resulting image might be different in that in two runs the result is different. Consider run (a) that runs in a container environment on Linux x86_64 with cgroup v2 (a kernel feature not part of the container) and (b) that runs on a container environment on Linux x86_64 with cgroup v1. This loads different sets of classes, AFAIK. Something to think about, maybe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the heads up. We should record if cgroup v2 or cgroup v1 was used in a containerized build.
58ed450
to
ef96aad
Compare
I moved the contents of |
One more note: the |
…nd LocatableMultiOptionValue.Paths
22f8b1b
to
e665713
Compare
Good idea. See #5473 (comment) |
No description provided.