Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-48354] Consolidate application module name detection. #7454

Merged
merged 18 commits into from
Oct 12, 2023

Conversation

graalvmbot
Copy link
Collaborator

@graalvmbot graalvmbot commented Sep 19, 2023

This PR re-implements the module name detection needed in the driver to not require running a jvm command anymore.

In addition to that there are some smaller cleanups.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 19, 2023
@olpaw olpaw requested a review from jerboaa September 20, 2023 10:45
@jerboaa
Copy link
Collaborator

jerboaa commented Sep 20, 2023

@olpaw Thanks for the heads-up. This still fails the build with --no-jlinking option. Do you want to fix this as part of this PR or shall I with a rebased version of #7205?

@olpaw
Copy link
Member

olpaw commented Sep 20, 2023

This still fails the build with --no-jlinking option.

The failing that is related to the splitting up of graal-sdk/truffle jars can also be fixed in a follow PR provided by you.

I still have issues with this PR as it adds a dependency to libstdc++. This is not a problem for the driver but for native-image agent (which then also depends on libstdc++) that gets loaded into a jvm and then there can be libstdc++ conflicts ... so what I currently have is still WIP.

@graalvmbot graalvmbot force-pushed the paw/GR-48354 branch 3 times, most recently from 75a1b8e to dae55bd Compare October 3, 2023 14:25
@olpaw
Copy link
Member

olpaw commented Oct 4, 2023

@jerboaa this is now in good shape and will be merged soon. Once on master please create a PR with any remaining changes needed for mandrel.

@jerboaa
Copy link
Collaborator

jerboaa commented Oct 4, 2023

@jerboaa this is now in good shape and will be merged soon. Once on master please create a PR with any remaining changes needed for mandrel.

@olpaw Excellent! Sure I have a PR handy locally. I'll be rebasing #7205 as far as the patch is concerned. Hope that's OK too?

@olpaw
Copy link
Member

olpaw commented Oct 4, 2023

@olpaw Excellent! Sure I have a PR handy locally. I'll be rebasing #7205 as far as the patch is concerned. Hope that's OK too?

Yes, except for the changes in buildImage(). These you do not need anymore.

@jerboaa
Copy link
Collaborator

jerboaa commented Oct 4, 2023

@olpaw Excellent! Sure I have a PR handy locally. I'll be rebasing #7205 as far as the patch is concerned. Hope that's OK too?

Yes, except for the changes in buildImage(). These you do not need anymore.

Sure, understood. Thanks!

@fniephaus
Copy link
Member

@jerboaa do you approve this PR?

@jerboaa
Copy link
Collaborator

jerboaa commented Oct 10, 2023

@jerboaa do you approve this PR?

Sure. Sorry if this was waiting on myself (if so, I wasn't aware).

@jerboaa
Copy link
Collaborator

jerboaa commented Oct 11, 2023

@fniephaus @olpaw Any ETA when this will merge?

@fniephaus
Copy link
Member

It's on the top of the merge queue, should be merged in the next couple of minutes.

@jerboaa
Copy link
Collaborator

jerboaa commented Oct 11, 2023

Great, thanks!

@fniephaus
Copy link
Member

should be merged in the next couple of minutes.

Famous last words. Turns out the PR hit an infrastructure issue and needs to go through the gate again.

@jerboaa
Copy link
Collaborator

jerboaa commented Oct 12, 2023

OK. Thanks for the update.

@graalvmbot graalvmbot closed this Oct 12, 2023
@graalvmbot graalvmbot merged commit 5e8f38e into master Oct 12, 2023
@graalvmbot graalvmbot deleted the paw/GR-48354 branch October 12, 2023 20:14
@olpaw
Copy link
Member

olpaw commented Oct 16, 2023

@jerboaa this is now on master. Feel free to create your PR now that fixes the remaining issues that are needed for mandrel.

@jerboaa
Copy link
Collaborator

jerboaa commented Oct 16, 2023

@jerboaa this is now on master. Feel free to create your PR now that fixes the remaining issues that are needed for mandrel.

@olpaw Yes, thanks! Already done in #7205. Please review once you get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants