-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GR-48354] Consolidate application module name detection. #7454
Conversation
0f8eda2
to
f104f39
Compare
The failing that is related to the splitting up of graal-sdk/truffle jars can also be fixed in a follow PR provided by you. I still have issues with this PR as it adds a dependency to libstdc++. This is not a problem for the driver but for native-image agent (which then also depends on |
4a069aa
to
fa20307
Compare
…geModulePath is empty
75a1b8e
to
dae55bd
Compare
dae55bd
to
c629a5c
Compare
@jerboaa this is now in good shape and will be merged soon. Once on master please create a PR with any remaining changes needed for mandrel. |
@jerboaa do you approve this PR? |
Sure. Sorry if this was waiting on myself (if so, I wasn't aware). |
@fniephaus @olpaw Any ETA when this will merge? |
It's on the top of the merge queue, should be merged in the next couple of minutes. |
Great, thanks! |
Famous last words. Turns out the PR hit an infrastructure issue and needs to go through the gate again. |
OK. Thanks for the update. |
@jerboaa this is now on master. Feel free to create your PR now that fixes the remaining issues that are needed for mandrel. |
This PR re-implements the module name detection needed in the driver to not require running a jvm command anymore.
In addition to that there are some smaller cleanups.