Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-48515] Enforce .exports files gets safely created for a cmd-launcher. #7557

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

graalvmbot
Copy link
Collaborator

This PR changes the creation time of the .exports-files to mx build time.
Now after running mx build we will already have:

<graalvm-home>/lib/svm/native-image-configure.cmd
<graalvm-home>/lib/svm/native-image-configure.export-list
<graalvm-home>/lib/svm/native-image.cmd
<graalvm-home>/lib/svm/native-image.export-list
...

This prevents the concurrent writing bug of the same.exportsfile on concurrent first use of native-image.cmd that could happen with the previous solution.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 5, 2023
@graalvmbot graalvmbot merged commit 7223218 into master Oct 10, 2023
@graalvmbot graalvmbot deleted the paw/GR-48515 branch October 10, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants