[GR-53596] Support dumping NMT reports on SIGUSR1 #8876
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
roberttoyonaga
force-pushed
the
dump-nmt-on-signal
branch
from
1f38ec0 to
1316630
Compare
roberttoyonaga
force-pushed
the
dump-nmt-on-signal
branch
from
1316630 to
930c597
Compare
christianhaeubl
changed the title
|
Dumping NMT reports through JCMD is preferred over this method using signals. If #9232 is integrated, we should not integrate this PR. |
|
The plan is to integrate #9232, so I am closing this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for dumping NTM reports on SIGUSR1. SIGUSR1 is shared with the heap dump feature. If both heap dump and NMT features are included in the image, then both types of report will be dumped.
This change will allow users to sample NMT data at arbitrary points in application execution. Previously, you could only get a report once the application finishes.
Related GH issue: #8814