Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JVSC-249] Fix code-folding for LSP clients that support line-folding only #308

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

sid-srini
Copy link
Member

Backported apache/netbeans#7921 to fix netbeans unit tests breakage due to uninitialised NbCodeClientCapabilities.getClientCapabilities() by adding a null check in the initialisation of lineFoldingOnly in TextDocumentServiceImpl.foldingRange().

… only

Backported apache/netbeans#7921 to fix unit tests breakage due to uninitialised
`NbCodeClientCapabilities.getClientCapabilities()` by adding a null check in the
initialisation of `lineFoldingOnly` in `TextDocumentServiceImpl.foldingRange()`.

Signed-off-by: Siddharth Srinivasan <[email protected]>
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 29, 2024
@sid-srini sid-srini requested a review from Achal1607 October 29, 2024 08:26
Copy link
Member

@Achal1607 Achal1607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing it.

@sid-srini sid-srini merged commit f50358c into oracle:main Oct 29, 2024
3 checks passed
@sid-srini
Copy link
Member Author

LGTM. Thanks for fixing it.

Thanks @lahodaj. Thanks @Achal1607.

@sid-srini sid-srini deleted the jvsc249_code_folding_if_else branch October 29, 2024 09:40
@sid-srini sid-srini added this to the JVSC 23.0.1 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants