No need to set the constants for updateAnonymousChildrenModules()

oracle · May 30, 2023 · 88935ce · 88935ce
1 parent 3f4a07d
commit 88935ce
Showing 1 changed file with 17 additions and 11 deletions.
diff --git a/src/main/java/org/truffleruby/core/module/ModuleFields.java b/src/main/java/org/truffleruby/core/module/ModuleFields.java
@@ -163,19 +163,24 @@ public void afterConstructed() {
         getName();
     }
 
-    public RubyConstant getAdoptedByLexicalParent(
-            RubyContext context,
-            RubyModule lexicalParent,
-            String name,
+    public RubyConstant getAdoptedByLexicalParent(RubyContext context, RubyModule lexicalParent, String name,
             Node currentNode) {
+        return getAdoptedByLexicalParent(context, lexicalParent, name, currentNode, true);
+    }
+
+    private RubyConstant getAdoptedByLexicalParent(RubyContext context, RubyModule lexicalParent, String name,
+            Node currentNode, boolean setConstant) {
         assert name != null;
 
-        RubyConstant previous = lexicalParent.fields.setConstantInternal(
-                context,
-                currentNode,
-                name,
-                rubyModule,
-                null);
+        RubyConstant previous = null;
+        if (setConstant) {
+            previous = lexicalParent.fields.setConstantInternal(
+                    context,
+                    currentNode,
+                    name,
+                    rubyModule,
+                    null);
+        }
 
         if (!hasFullName()) {
             // Tricky, we need to compare with the Object class, but we only have a Class at hand.
@@ -208,7 +213,8 @@ public void updateAnonymousChildrenModules(RubyContext context) {
                             context,
                             rubyModule,
                             entry.getKey(),
-                            null);
+                            null,
+                            false);
                 }
             }
         }