Remove "fails" tags for methods that are passing spec/truffle/methods_spec.rb #3417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
rwstauner
added
shopify
and removed
OCA Verified
|
It makes sense to have single PR with untagging passing specs. It would make it faster to have the internal CI passed. Also I suppose there might be tagged language specs that got passing after switching to Prism. |
|
That makes sense. I wasn't sure if there'd be any difference in the effort to review them or in the commands I used to find them. Would you like me to put this into the other one and close this? |
|
Moved this into to #3418 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the MatchData ones were unnecessary, then ran
jt purge spec/truffle/methods_spec.rband it found more that pass.