Support null encoding for rb_enc_interned_str_cstr #3480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
thomasmarshall
commented
Mar 6, 2024
thomasmarshall
commented
Mar 6, 2024
thomasmarshall
force-pushed
the
rb-enc-str-new-cstr-null-enc
branch
from
cf60136 to
d16baa4
Compare
This commit adds support for a null pointer to be passed as the encoding argument to rb_enc_interned_str_cstr. When we implemented this function originally, we noticed that the CRuby behavior did not match the header documentation, so we opted not to support it. However, this has now been fixed in CRuby [1], so we can fix it here as well. [1]: ruby/ruby#10169
thomasmarshall
force-pushed
the
rb-enc-str-new-cstr-null-enc
branch
from
d16baa4 to
2dea520
Compare
andrykonchin
approved these changes
Mar 19, 2024
andrykonchin
added
the
in-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for a null pointer to be passed as the encoding argument to
rb_enc_interned_str_cstr.When we implemented this function originally, we noticed that the CRuby behavior did not match the header documentation, so we opted not to support it. However, this has now been fixed in CRuby, so we can fix it here as well.