[GR-19220] Support timezone object argument to Time.{at,new} and Time#{getlocal,localtime} (#3740) #3786

graalvmbot · 2025-02-06T18:19:46Z

No description provided.

…localtime} closes #1717 For compatibility with https://bugs.ruby-lang.org/issues/14850 Co-authored-by: Manef Zahra <[email protected]> Co-authored-by: Patrick Lin <[email protected]>

Expected TypeError ((?-mix:can't convert \w+ into an exact number)) but got: TypeError (wrong argument type Object (expected Integer))

> Expected TypeError ((?-mix:can't convert \w+ into an exact number)) > but got: TypeError (wrong argument type Object (expected Integer)) close enough

In CRuby this spec passes because it is a Time-Like object (Time::tm) that defines to_time. We are using an actual Time object here so we need the method for the spec to pass.

…annot be converted into numeric

…teger

…stance of Time and take into account #utc_offset

rwstauner and others added 22 commits February 6, 2025 20:10

Support timezone object argument to Time.{at,new} and Time#{getlocal,…

a722c11

…localtime} closes #1717 For compatibility with https://bugs.ruby-lang.org/issues/14850 Co-authored-by: Manef Zahra <[email protected]> Co-authored-by: Patrick Lin <[email protected]>

Ignore message content in TypeError assertion for Time#getlocal

35a60fc

Expected TypeError ((?-mix:can't convert \w+ into an exact number)) but got: TypeError (wrong argument type Object (expected Integer))

Update spec to show that when offset is numeric zone is nil

054754e

Ensure zone object is a String before calling encoding methods

8f3e304

Support time zone args that define local_to_utc

087eaec

Set time zone to the object that did the conversion

dbc9563

Remove spec error message and just match on type

eeda7d4

> Expected TypeError ((?-mix:can't convert \w+ into an exact number)) > but got: TypeError (wrong argument type Object (expected Integer)) close enough

Make to_time available without needing to require date

3fcadc8

In CRuby this spec passes because it is a Time-Like object (Time::tm) that defines to_time. We are using an actual Time object here so we need the method for the spec to pass.

Untag additional time specs that pass now

464aadb

Fix coerce_to_exact_num and raise proper exception for objects that c…

49b1341

…annot be converted into numeric

Fix Time{.now,.at,#getlocal,#localtime} when #utc_to_local returns In…

7ff145c

…teger

Fix Time.now and set timezone object

c8c6550

Fix Time{.now,.at,#getlocal,#localtime} when #utc_to_local returns in…

696d17a

…stance of Time and take into account #utc_offset

Polish specs for Time.new method

aa9f839

Untag passing specs for Time

ddb8474

Refactor Truffle::Type.coerce_to_utc_offset

be5db86

Cleanup calculate_utc_offset_with_timezone_object

c45eecf

Move Time-related methods from Truffle::Type to Truffle::TimeOperations

cda07c2

Update specs for Time-like object and check only documented methods

0e34d77

Test Time class public methods presence

e77028e

Clean up Time#zone method and remove outdated encoding-specific logic

5553611

Refactor Truffle::Type.coerce_to_exact_num()

f4eea14

oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 6, 2025

graalvmbot closed this Feb 10, 2025

graalvmbot merged commit 2e1acf1 into master Feb 10, 2025
25 of 27 checks passed

graalvmbot deleted the timezone-arg branch February 10, 2025 15:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GR-19220] Support timezone object argument to Time.{at,new} and Time#{getlocal,localtime} (#3740) #3786

[GR-19220] Support timezone object argument to Time.{at,new} and Time#{getlocal,localtime} (#3740) #3786

graalvmbot commented Feb 6, 2025

[GR-19220] Support timezone object argument to Time.{at,new} and Time#{getlocal,localtime} (#3740) #3786

[GR-19220] Support timezone object argument to Time.{at,new} and Time#{getlocal,localtime} (#3740) #3786

Conversation

graalvmbot commented Feb 6, 2025