Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: complete migration to Biome #576

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

ematipico
Copy link
Contributor

@ematipico ematipico commented Dec 11, 2023

This is the last PR that moves the entire orama monorepo to Biome.

There's the list of changes:

  • I removed the files.include and added files.ignore instead. The contents of the array are copied from the .prettierignore file.
  • The events.json file is formatted now, and that's what files.maxSize is for. The size of the file doesn't impact the formatting performance at all, so it's safe to handle it.
  • I removed prettier from the dependencies.
  • I updated the lint-staged script to run format:hook. This is different from format command, because it adds the --no-error-on-unmatched, which prevents Biome from throwing an error if no files were processed.
  • I removed prettier's files

Here's the performance of the format command on my machine:

Formatted 787 file(s) in 500ms

I think it should be all. Let me know if there's something missing.

If welcomed, I could also integrate:

  • import sorting
  • linting (in conjunction with eslint)

Copy link

vercel bot commented Dec 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
orama-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2023 11:25am

@micheleriva micheleriva merged commit 091b3ca into oramasearch:main Dec 11, 2023
2 checks passed
@ematipico ematipico deleted the chore/finish-migration branch December 11, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants