-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for retry? #147
Comments
Thanks for mentioning the retry. The retry functionality is planned after the release of Retrying seems to be a simple feature, but it is not. There are two levels of retry: HTTP level retry and application level retry.
We will probably add retry logic in the |
Excellent! And yes of course a good design goes without saying. |
@shizhMSFT I am interested in implementing the retry logic in the remote pkg. What is the process to propose a design? |
@souleb Thanks for your interest! ORAS community is open to any kind of proposal and design. Now you can create a discussion to add your proposal. Going forward, we will create a separate folder to store the proposal docs and template. What do you think of it? |
Great! Thanks. |
Discussed in #232 |
If implemented, this will provide a default http client with retry. The retry function is an exponential back off 0.25s * 2^n ± 10% and max 5 attempts. The client is the default client of `auth.Client` BREAKING CHANGE: `auth.DefaultClient` uses `retry.DefaultClient` instead of `http.DefaultClient` Fixes: #147 Co-authored-by: Shiwei Zhang <[email protected]> Signed-off-by: Soule BA <[email protected]>
hey oras developers!
I've been using oras in CI, and I typically need to wrap it in some kind of retry with exponential backoff. To compare to another registry client, when I use docker it will retry pulling blobs, and same with Singularity. How could it work? I suspect there could be some
Retry-After
header returned from a server, and if not, the user could specify a number of retries. Would this be something oras could support? In practice I have seen a lot of push failures in my CI when using oras, and probably just the fault of the receiving end.The text was updated successfully, but these errors were encountered: