feat: add a host-based auth cache as a fallback #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktarplee
requested review from
sajayantony,
shizhMSFT,
SteveLasker and
Wwwsylvia
as code owners
|
This PR obviously still needs
|
ktarplee
commented
Nov 28, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
==========================================
+ Coverage 75.41% 75.46% +0.04%
==========================================
Files 59 59
Lines 5606 5640 +34
==========================================
+ Hits 4228 4256 +28
- Misses 1015 1019 +4
- Partials 363 365 +2 ☔ View full report in Codecov by Sentry. |
ktarplee
force-pushed
the
650-auth
branch
2 times, most recently
from
6d09a8f to
7e865b8
Compare
|
I also added unit tests for the hostCache and exported |
shizhMSFT
changed the title
shizhMSFT
approved these changes
Dec 29, 2023
|
@ktarplee LoL. The DCO check failed. Could you fix that? |
The cache is implemented as a fallback cache with a host-based as the fallback. Signed-off-by: Kyle M. Tarplee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new exported method called
NewRobustCache()and changes theDefaultCacheto use the robust cache. The robust cache uses scoped based auth but falls back to host based auth to better handle the situations described in #650 but retain the benefits of scoped based auth (where the token for a repo might be different than another repo in the same registry).Closes #650