feat: Referrers support for content.ReadOnlyGraphStorage #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangxiaoxuan273
requested review from
sajayantony,
shizhMSFT,
SteveLasker and
Wwwsylvia
as code owners
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #659 +/- ##
==========================================
+ Coverage 75.32% 75.36% +0.04%
==========================================
Files 59 59
Lines 5499 5570 +71
==========================================
+ Hits 4142 4198 +56
- Misses 1001 1011 +10
- Partials 356 361 +5 ☔ View full report in Codecov by Sentry. |
qweeah
reviewed
Dec 18, 2023
qweeah
reviewed
Dec 18, 2023
qweeah
reviewed
Dec 18, 2023
qweeah
reviewed
Dec 18, 2023
shizhMSFT
reviewed
Dec 18, 2023
Wwwsylvia
reviewed
Dec 19, 2023
wangxiaoxuan273
force-pushed
the
referrers
branch
3 times, most recently
from
73a18b1 to
efd9a57
Compare
wangxiaoxuan273
changed the title
wangxiaoxuan273
changed the title
content.ReadOnlyGraphStorage
wangxiaoxuan273
changed the title
content.ReadOnlyGraphStorage
shizhMSFT
reviewed
Dec 21, 2023
shizhMSFT
reviewed
Dec 21, 2023
Wwwsylvia
reviewed
Dec 21, 2023
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
wangxiaoxuan273
force-pushed
the
referrers
branch
from
6147d36 to
7ec19a1
Compare
shizhMSFT
requested changes
Dec 25, 2023
Signed-off-by: Xiaoxuan Wang <[email protected]>
shizhMSFT
reviewed
Dec 25, 2023
There was a problem hiding this comment.
@wangxiaoxuan273 The code LGTM. Can you increase the unit test code coverage at least to the current level of 75%?
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides
Referrerssupport for thecontent.ReadOnlyGraphStorageinterface, which includesoci.Store.Resolves #392