Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --template and support --format go-template=TEMPLATE experience #1377

Merged
merged 35 commits into from
May 14, 2024

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented May 8, 2024

What this PR does / why we need it:
This PR implements latest change in #1199

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 95.16129% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 85.02%. Comparing base (96d64da) to head (70cd7f0).

Files Patch % Lines
cmd/oras/internal/display/handler.go 91.11% 1 Missing and 3 partials ⚠️
cmd/oras/root/discover.go 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1377      +/-   ##
==========================================
+ Coverage   84.91%   85.02%   +0.10%     
==========================================
  Files         107      107              
  Lines        3739     3806      +67     
==========================================
+ Hits         3175     3236      +61     
- Misses        336      341       +5     
- Partials      228      229       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

qweeah added 14 commits May 9, 2024 03:13
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
cmd/oras/internal/option/format.go Outdated Show resolved Hide resolved
cmd/oras/internal/option/format.go Outdated Show resolved Hide resolved
cmd/oras/internal/option/format.go Outdated Show resolved Hide resolved
cmd/oras/internal/option/format.go Outdated Show resolved Hide resolved
cmd/oras/internal/option/format.go Outdated Show resolved Hide resolved
cmd/oras/internal/option/format.go Outdated Show resolved Hide resolved
Signed-off-by: Billy Zha <[email protected]>
cmd/oras/internal/option/format.go Outdated Show resolved Hide resolved
cmd/oras/internal/option/format.go Outdated Show resolved Hide resolved
cmd/oras/internal/option/format.go Outdated Show resolved Hide resolved
cmd/oras/internal/option/format.go Outdated Show resolved Hide resolved
cmd/oras/root/discover.go Show resolved Hide resolved
qweeah added 5 commits May 13, 2024 14:51
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 674b16e into oras-project:main May 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants