-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: copy prompt skipped was missing #1484
fix: copy prompt skipped was missing #1484
Conversation
Signed-off-by: Terry Howe <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1484 +/- ##
=======================================
Coverage 85.54% 85.54%
=======================================
Files 113 113
Lines 3936 3936
=======================================
Hits 3367 3367
Misses 342 342
Partials 227 227 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Billy Zha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, added unit test for that.
The CodeCov scan seems failed in the CI. Should we fix it before merging this PR? |
Coverage on this file is 90% from my reading, but it just happens that renaming |
I'm going to ignore the bogus coverage report. |
What this PR does / why we need it:
This is a bit confusing, but previously, OnCopySkipped prompted with "Exists" and PostCopy prompted with "Skipped". I think this was changed accidentally.
https://github.com/oras-project/oras/blob/release-1.2/cmd/oras/root/cp.go#L180:L189