Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy prompt skipped was missing #1484

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

TerryHowe
Copy link
Member

What this PR does / why we need it:

This is a bit confusing, but previously, OnCopySkipped prompted with "Exists" and PostCopy prompted with "Skipped". I think this was changed accidentally.

https://github.com/oras-project/oras/blob/release-1.2/cmd/oras/root/cp.go#L180:L189

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.54%. Comparing base (d4eccf4) to head (7e29fa1).
Report is 1 commits behind head on main.

Files Patch % Lines
cmd/oras/internal/display/status/text.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1484   +/-   ##
=======================================
  Coverage   85.54%   85.54%           
=======================================
  Files         113      113           
  Lines        3936     3936           
=======================================
  Hits         3367     3367           
  Misses        342      342           
  Partials      227      227           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, added unit test for that.

@FeynmanZhou
Copy link
Member

The CodeCov scan seems failed in the CI. Should we fix it before merging this PR?

@TerryHowe
Copy link
Member Author

Coverage on this file is 90% from my reading, but it just happens that renaming successors happens to touch a part of the code that is not tested. I think it makes sense to merge anyway here.

@TerryHowe
Copy link
Member Author

I'm going to ignore the bogus coverage report.

@TerryHowe TerryHowe merged commit 5792c35 into oras-project:main Aug 22, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants