Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark --oci-layout-path as experimental #1607

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

Horiodino
Copy link
Contributor

@Horiodino Horiodino commented Jan 16, 2025

What this PR does / why we need it:

marked --oci-layout-path as experimental

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1582

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.30%. Comparing base (8a31d9b) to head (45a5764).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1607      +/-   ##
==========================================
- Coverage   84.34%   84.30%   -0.04%     
==========================================
  Files         120      120              
  Lines        5449     5449              
==========================================
- Hits         4596     4594       -2     
- Misses        606      608       +2     
  Partials      247      247              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Horiodino
Copy link
Contributor Author

Horiodino commented Jan 18, 2025

I’m not sure I understand the need for a test case for that, as I’ve checked and all tests pass locally.

Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

@shizhMSFT shizhMSFT changed the title marked --oci-layout-path as experimental fix: mark --oci-layout-path as experimental Jan 21, 2025
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TerryHowe TerryHowe merged commit ad8c845 into oras-project:main Jan 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--oci-layout-path should be marked as experimental
4 participants