Fix regression in v0.11.0 #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the default for writer opt 'IgnoreNoName' to be true. This was set to false, and causing the example to not run properly. A new option 'WithErrorOnNoName' has been added to be used in cases when this behaviour is expected. The existing option 'WithIgnoreNoName' has now been deprecated. A simple bash-based acceptance test has been added to prevent this issue in the future. This starts a registry, compiles the example into a binary, and makes sure it runs properly. This test is now run in CI. Signed-off-by: Josh Dolitsky <[email protected]>
Signed-off-by: Josh Dolitsky <[email protected]>
Signed-off-by: Josh Dolitsky <[email protected]>
Signed-off-by: Josh Dolitsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default for writer opt 'IgnoreNoName' to be true. This was set to false, and causing the example to not run properly.
A new option 'WithErrorOnNoName' has been added to be used in cases when this behaviour is expected. The existing option 'WithIgnoreNoName' has now been deprecated.
A simple bash-based acceptance test has been added to prevent this issue in the future. This starts a registry, compiles the example into a binary, and makes sure it runs properly. This test is now run in CI.
Fixes #246
Alternative to #247 and #249