added basename to be visible on create language use case

[sabinabarbu]

No description provided.

[royteeuwen]

@sabinabarbu thanks for the PR. I do think that this alone will not show the basename though. Can you show a screenshot where you show the result of the change? By default the basename is already shown when creating a new dictionary? See screenshot:

[bdhoine]

@sabinabarbu and when adding a language you get the basename from the overview page, what do you want to achieve?

[bdhoine]

see also questions in conversation ;)

[bdhoine]

this will add a field but it's nowhere included in a dialog

[sabinabarbu]

https://github.com/orbinson/aem-dictionary-translator/blob/main/ui.apps/src/main/content/jcr_root/apps/aem-dictionary-translator/content/granite/dialog/dictionary/language/create/.content.xml

[sabinabarbu]

The fix is for create language use case not for create dictionary. In this file below you can find basename field used but it was not defined.
"basename
jcr:primaryType="nt:unstructured"
sling:resourceType="granite/ui/components/foundation/include"
path="/apps/aem-dictionary-translator/content/granite/field/basename"

After the fix, basename is visible when creating the language:

[bdhoine]

@sabinabarbu thanks for your contribution, while checking the specs (https://sling.apache.org/documentation/bundles/internationalization-support-i18n.html#resourcebundle-with-base-names-1) we see that a basename actually can be multivalued, would you mind contributing that as well?

Please also update the CHANGELOG.md

[royteeuwen]

any idea on when / if you could provide the update @sabinabarbu ? We'd want to cut a release when the pr's of @kwin are merged :)

[sabinabarbu]

any idea on when / if you could provide the update @sabinabarbu ? We'd want to cut a release when the pr's of @kwin are merged :)

I don't know exactly when I get the time for this.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud