Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix compat go1.20 #37

Merged
merged 1 commit into from
Dec 21, 2024
Merged

fix: fix compat go1.20 #37

merged 1 commit into from
Dec 21, 2024

Conversation

TropicalDog17
Copy link

@TropicalDog17 TropicalDog17 commented Dec 21, 2024 •
edited
Loading

Summary of changes

go mod tidy -go=1.20 -compat=1.20 to find problematic packages

Checklist before merge

  • use go1.20, go mod tidy not change anything, make build and make install works.
  • use go1.21, go mod tidy not change anything, make build and make install works.

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@TropicalDog17 TropicalDog17 changed the base branch from main to develop December 21, 2024 10:23
@TropicalDog17 TropicalDog17 merged commit b3df221 into develop Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TropicalDog17