Sub task benchmark #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjari-orb
reviewed
Feb 28, 2025
| @@ -144,7 +144,7 @@ def __init__( | |||
|
|
|||
There was a problem hiding this comment.
Minor nit, can we undo the changes to other files, so that merging back into browsergym is easier in the future
| @@ -69,7 +69,7 @@ def _normalize_number(text: str) -> str: | |||
|
|
|||
|
|
|||
| def _answer_to_bags( | |||
| @@ -237,15 +237,15 @@ def override_property(task, env, property): | |||
| browser_args = [] | |||
| from subtaskbench import Evaluator | ||
|
|
||
| self.evaluator = Evaluator( | ||
| start_url=self.task_config["start_url"], |
There was a problem hiding this comment.
Hmm so the start URL field might be a problem for this benchmark, because it will be ephemeral and thus cannot be read from a pre-defined config. One thing we can do let this be an environment id and pass it to a an handler in this file which can return the correct start url (can be left empty for now).
The same applies to the creation of the playwright.sync_api.Page as well.
| start_url=self.task_config["start_url"], | ||
| goal=self.task_config["goal"], | ||
| evaluation_script=self.task_config["evaluation_script"], | ||
| expected_output=self.task_config["expected_output"], |
There was a problem hiding this comment.
What is the expected output field expected to look like? Is this for information seeking tasks? (eg, string_match, fuzzy match type evals)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.