Flatten JSON in query results #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taliaga
approved these changes
Jun 18, 2019
Open
|
have also updated the spec in the sdk repo to reflect the change to the value array type, see: |
This was referenced Jun 24, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the flattening JSON query responses as outlined in #213 and additionally changes the array type of values returned by the queries from an array of numbers to an array of any type. The reason for the latter change is that attribute values may not only be numbers, but any of the valid types permitted by the NGSI spec.
Important: Backward compatibility
The implemented changes break API backward compatibility so it will have to be managed accordingly at API and release level---e.g. new API version, advertise change, etc.