You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Orchid\Icons\IconFinder::getContent(): Argument #3 ($dir) must be of type string, bool given, called in /opt/apps/app-source/vendor/orchid/blade-icons/src/IconFinder.php on line 66
To Reproduce
Steps to reproduce the behavior:
Open the notifications page when there are no notifications
Expected behavior
Apparently it now throws an exception when there is no icon, I didn’t notice this behavior before
Server (please complete the following information):
Platfrom Version: 14.26
Laravel Version: 10.48
PHP Version: 8.1
Additional context
The iconNotFound method should return bs.bell in the NotificationTable class:
<?phpdeclare(strict_types=1);
namespaceOrchid\Platform\Http\Layouts;
useOrchid\Screen\Layouts\Table;
useOrchid\Screen\TD;
class NotificationTable extends Table
{
/** * Data source. * * @var string */public$target = 'notifications';
/** * @return TD[] */publicfunctioncolumns(): array
{
return [
TD::make('Message', __('Messages'))
->cantHide()
->render(staticfn ($notification) => view('platform::partials.notification', [
'notification' => $notification,
])),
];
}
publicfunctiontextNotFound(): string
{
return__('No notifications');
}
publicfunctioniconNotFound(): string
{
return'bell';
}
publicfunctionsubNotFound(): string
{
return__('You currently have no notifications, but maybe they will appear later.');
}
}
The text was updated successfully, but these errors were encountered:
Thank you for pointing out the missing prefix on the icon. I was unable to reproduce this issue on the latest version, likely due to the orchid/blade-icons package (tested on version 4). To prevent this issue, I have added the bs prefix, which is the default for Bootstrap icons. This prefix is available starting from version 14.26.1, so please update your package.
Describe the bug
Error on notifications page:
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Apparently it now throws an exception when there is no icon, I didn’t notice this behavior before
Server (please complete the following information):
Additional context
The iconNotFound method should return bs.bell in the NotificationTable class:
The text was updated successfully, but these errors were encountered: