Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commit-fee-rate option for specifying individual fee rates #1490

Merged
merged 3 commits into from
Feb 6, 2023

Conversation

andrewtoth
Copy link
Contributor

Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't able to do a full review yet, sorry for the delay! But wanted to note that we should probably allow commit-fee-rate to be less than fee-rate. See comment!

src/subcommand/wallet/inscribe.rs Outdated Show resolved Hide resolved
@casey casey enabled auto-merge (squash) February 6, 2023 23:20
@casey
Copy link
Collaborator

casey commented Feb 6, 2023

This looks great! I pushed f04eb06 to make the help string shorter, hopefully it looks okay!

@casey casey merged commit f2d8d0d into ordinals:master Feb 6, 2023
@andrewtoth andrewtoth deleted the commit-fee-rate branch February 7, 2023 23:03
popcnt1 pushed a commit to popcnt1/ord that referenced this pull request Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting higher fee rate for commit transaction separately
2 participants