-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "amount" field to "wallet inscriptions" output. #1928
Add "amount" field to "wallet inscriptions" output. #1928
Conversation
The lint failures go away after #1923. |
this is always going to be 10000 until we have an option to change the output postage amount, or am I missing something? |
06d2411
to
df88698
Compare
When sending around inscriptions the postage will decrease over time. It will only be replenished if it would go below the dust limit. So this change makes sense. |
7a04d5d
to
df88698
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing with Casey. This is missing a few things that he will address in his review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This is a good addition.
This requires a test! We should have an integration test that the returned postage
field is correct. Add one in tests/wallet/inscriptions.rs
.
…-wallet-inscriptions
* Add contributing section (ordinals#2261) * Implement clean index shutdown to prevent index corruption (with clippy updates for Rust 1.71) (ordinals#2275) * gracefully shutdown index update thread to prevent index corruption * Use `next_back()` instead of `rev().next()` for rust 1.71 --------- Co-authored-by: victorkirov <[email protected]> * Modify `ord list` output to include the end of each range (ordinals#1998) * Don't create default data directory if --index overrides it (ordinals#1991) * Fix docs inconsistency (ordinals#2276) * Fix ordering for reinscriptions and show all reinscriptions for sat (ordinals#2279) * Add satpoint and address to index export (ordinals#2284) * Update bitcoin dependencies (ordinals#2281) * Update redb (ordinals#2294) * Add retry to fetcher (ordinals#2297) * Clean up deploy scripts (ordinals#2298) * Fix justfile recipe (ordinals#2299) * Release 0.8.1 (ordinals#2300) * Add `amount` field to `wallet inscriptions` output. (ordinals#1928) * Fix dust limit for padding in `TransactionBuilder` (ordinals#1929) * Inform user when redb starts in recovery mode (ordinals#2304) * Fix remote RPC wallet commands (ordinals#1766) * Select multiple utxos (ordinals#2303) Co-authored-by: Greg Martin <[email protected]> * feat: add outputs api --------- Co-authored-by: raph <[email protected]> Co-authored-by: victorkirov <[email protected]> Co-authored-by: gmart7t2 <[email protected]> Co-authored-by: ordinally <[email protected]> Co-authored-by: Carlos Alaniz <[email protected]> Co-authored-by: Greg Martin <[email protected]>
Allow people to check the postage on each of their inscriptions.