Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ord decode command #2401

Merged
merged 7 commits into from
Aug 31, 2023
Merged

Add ord decode command #2401

merged 7 commits into from
Aug 31, 2023

Conversation

casey
Copy link
Collaborator

@casey casey commented Aug 30, 2023

Decodes a transaction from a file, useful for debugging inscription parsing.

@casey casey requested a review from raphjaph August 30, 2023 19:15
rot13maxi
rot13maxi reviewed Aug 31, 2023
View reviewed changes
src/subcommand/decode.rs Outdated Show resolved Hide resolved
raphjaph
raphjaph reviewed Aug 31, 2023
View reviewed changes
tests/decode.rs Outdated
inscriptions: vec![Inscription {
body: Some(vec![0, 1, 2, 3]),
content_type: Some(vec![
116, 101, 120, 116, 47, 112, 108, 97, 105, 110, 59, 99, 104, 97, 114, 115, 101, 116, 61,
Copy link
Collaborator

@raphjaph raphjaph Aug 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make more readable, so that we can see that it corresponds to the inscription above

raphjaph
raphjaph reviewed Aug 31, 2023
View reviewed changes
tests/decode.rs Outdated
body: Some(vec![0, 1, 2, 3]),
content_type: Some(vec![
116, 101, 120, 116, 47, 112, 108, 97, 105, 110, 59, 99, 104, 97, 114, 115, 101, 116, 61,
117, 116, 102, 45, 56
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

raphjaph
raphjaph requested changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits

raphjaph
raphjaph approved these changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@casey casey enabled auto-merge (squash) August 31, 2023 19:53
@casey casey merged commit 89fde16 into master Aug 31, 2023
@casey casey deleted the decode branch August 31, 2023 19:58
popcnt1 pushed a commit to popcnt1/ord that referenced this pull request Jan 11, 2025
@casey
Add decode command (ordinals#2401)
454d299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rot13maxi rot13maxi rot13maxi left review comments

@raphjaph raphjaph raphjaph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@casey @raphjaph @rot13maxi