Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML endpoint /inscriptions/block/<height>/<page> returns nothing after page 0 #2798

Merged
merged 8 commits into from
Dec 5, 2023

Conversation

gmart7t2
Copy link
Contributor

@gmart7t2 gmart7t2 commented Dec 2, 2023

Both Server::inscriptions_in_block_paginated() and InscriptionsBlockHtml::new() are removing the first page_index * page_size inscriptions. Only one of them should do it.

This commit fixes the issue.

Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Just simplified the logic a bit and wrote a test.

@raphjaph raphjaph enabled auto-merge (squash) December 5, 2023 19:19
@raphjaph raphjaph merged commit d0ae915 into ordinals:master Dec 5, 2023
6 checks passed
popcnt1 pushed a commit to popcnt1/ord that referenced this pull request Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants