Upgrading Firefox cask to v113 somehow corrupted the cask binary #4498

fabianschulz · 2023-05-10T15:40:18Z

fabianschulz
May 10, 2023

Output of `brew config`

HOMEBREW_VERSION: 4.0.17
ORIGIN: https://github.com/Homebrew/brew
HEAD: c0f8068573bbf886fdc78d3f9daca54d53e7e49e
Last commit: 2 days ago
Core tap origin: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 1d8c58a0aad7953501bd69df9f5014a6dfbf199e
Core tap last commit: 3 months ago
Core tap branch: master
Core tap JSON: 10 May 15:27 UTC
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_MAKE_JOBS: 8
Homebrew Ruby: 2.6.10 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: octa-core 64-bit arm_firestorm_icestorm
Clang: 14.0.3 build 1403
Git: 2.39.2 => /Library/Developer/CommandLineTools/usr/bin/git
Curl: 7.87.0 => /usr/bin/curl
macOS: 13.3.1-arm64
CLT: 14.3.0.0.1.1679647830
Xcode: N/A
Rosetta 2: false

Output of `brew doctor`

Warning: You have an unnecessary local Cask tap.
This can cause problems installing up-to-date casks.
Please remove it by running:
  brew untap homebrew/cask

Warning: You have an unnecessary local Core tap!
This can cause problems installing up-to-date formulae.
Please remove it by running:
 brew untap homebrew/core

Description of issue

Hi, I wanted to update my Firefox browser to the latest version, but somehow the upgrade process corrupted the installation and I'm unsure what to do next. I am afraid of removing and re-installing Firefox from scratch, since I have a ton of privacy addons configured.

I ran this as usual:

fabian@MacBook ~ % brew upgrade --greedy
==> Upgrading 1 outdated package:
firefox 112.0.2 -> 113.0

But for some reason something went wrong during installation of the v113 binary of Firefox:

==> Upgrading 1 outdated package:
firefox 112.0.2 -> 113.0
==> Upgrading firefox
==> Downloading https://raw.githubusercontent.com/Homebrew/homebrew-cask/(...)/Casks/firefox.rb
...100.0%
==> Downloading https://download-installer.cdn.mozilla.net/pub/firefox/releases/113.0/mac/en-US/Firefox%20113.0.dmg
...100.0%
==> Backing App 'Firefox.app' up to '/opt/homebrew/Caskroom/firefox/112.0.2/Firefox.app'
==> Removing App '/Applications/Firefox.app'
==> Unlinking Binary '/opt/homebrew/bin/firefox'
==> Moving App 'Firefox.app' to '/Applications/Firefox.app'
==> Purging files for version 113.0 of Cask firefox
==> Purging files for version 113.0 of Cask firefox
Warning: Reverting upgrade for Cask firefox
==> Purging files for version 112.0.2 of Cask firefox
Error: firefox: undefined method `artifacts' for #Hash:0x0000000140ac9658
Please report this issue:
https://docs.brew.sh/Troubleshooting
/opt/homebrew/Library/Homebrew/cask/upgrade.rb:127:in upgrade_casks
/opt/homebrew/Library/Homebrew/cmd/upgrade.rb:253:in upgrade_outdated_casks
/opt/homebrew/Library/Homebrew/cmd/upgrade.rb:137:in upgrade
/opt/homebrew/Library/Homebrew/brew.rb:94:in main

When trying to launch Firefox, Finder now complains that it "may be damaged or incomplete" and it cannot be started (writing this post on Safari).

Is there any way I can "resume" the upgrade?

Many thanks!
[Edit: I had to remove some characters like ' and <> in the GitHub comment field since it messed up the formatting]

Relevant casks

Firefox

Answered by timfallmk

May 10, 2023

Forcing a reinstall of the affected casks got me back on the road with no loss of settings.

brew install --cask google-chrome --force

View full answer

timfallmk · 2023-05-10T17:33:21Z

timfallmk
May 10, 2023

As someone else noted, this is likely related to changes in the upgrade mechanism of casks (to prevent them being quarantined/removed from the dock). I had a similar problem with the most recent upgrade of chrome and chrome canary.
Homebrew/brew#15138

3 replies

fabianschulz May 10, 2023
Author

Thanks for pointing this out @timfallmk ! If there is anything I can help with testing, I am happy to do so. If you had the same issue with your Chrome cask: did you find a way to "fix" the (broken) upgrade? If it's a bug in Brew itself and there is a hotfix in sight, I will of course be patient.

timfallmk May 10, 2023

Forcing a reinstall of the affected casks got me back on the road with no loss of settings.

brew install --cask google-chrome --force

Answer selected by fabianschulz

fabianschulz May 10, 2023
Author

Forcing a reinstall of the affected casks got me back on the road with no loss of settings.
brew install --cask google-chrome --force

Thank you @timfallmk , I can confirm that this "fixed" the broken cask upgrade. Settings and addons were fortunately not affected. I'll mark the thread as answered, but of course the issue in Homebrew/brew#15138 still persists until the root cause will be found.

timfallmk · 2023-05-10T18:10:49Z

timfallmk
May 10, 2023

Adding similar behavior from google-chrome and google-chrome-canary

==> Upgrading google-chrome to 113.0.5672.92
==> Downloading https://dl.google.com/chrome/mac/universal/stable/GGRO/googlechrome.dmg
######################################################################################################################################################################################################################################################### 100.0%
Warning: No checksum defined for cask 'google-chrome', skipping verification.
==> Uninstalling Cask google-chrome
==> Backing App 'Google Chrome.app' up to '/opt/homebrew/Caskroom/google-chrome/113.0.5672.63/Google Chrome.app'
==> Removing App '/Applications/Google Chrome.app'
==> Purging files for version 113.0.5672.63 of Cask google-chrome
==> Installing Cask google-chrome
==> Moving App 'Google Chrome.app' to '/Applications/Google Chrome.app'
cp: /opt/homebrew/Caskroom/google-chrome/113.0.5672.92/Google Chrome.app/*: No such file or directory
cp: /opt/homebrew/Caskroom/google-chrome/113.0.5672.92/Google Chrome.app/.*: No such file or directory
==> Purging files for version 113.0.5672.92 of Cask google-chrome
Error: Failure while executing; `/usr/bin/sudo -E -- /bin/cp -pR /opt/homebrew/Caskroom/google-chrome/113.0.5672.92/Google\ Chrome.app/\* /opt/homebrew/Caskroom/google-chrome/113.0.5672.92/Google\ Chrome.app/.\* /Applications/Google\ Chrome.app/` exited with 1. Here's the output:
cp: /opt/homebrew/Caskroom/google-chrome/113.0.5672.92/Google Chrome.app/*: No such file or directory
cp: /opt/homebrew/Caskroom/google-chrome/113.0.5672.92/Google Chrome.app/.*: No such file or directory

==> Upgrading google-chrome-canary to 115.0.5759.0
==> Downloading https://dl.google.com/chrome/mac/universal/canary/googlechromecanary.dmg
######################################################################################################################################################################################################################################################### 100.0%
Warning: No checksum defined for cask 'google-chrome-canary', skipping verification.
==> Uninstalling Cask google-chrome-canary
==> Backing App 'Google Chrome Canary.app' up to '/opt/homebrew/Caskroom/google-chrome-canary/115.0.5751.0/Google Chrome Canary.app'
==> Removing App '/Applications/Google Chrome Canary.app'
==> Purging files for version 115.0.5751.0 of Cask google-chrome-canary
==> Installing Cask google-chrome-canary
==> Moving App 'Google Chrome Canary.app' to '/Applications/Google Chrome Canary.app'
cp: /opt/homebrew/Caskroom/google-chrome-canary/115.0.5759.0/Google Chrome Canary.app/*: No such file or directory
cp: /opt/homebrew/Caskroom/google-chrome-canary/115.0.5759.0/Google Chrome Canary.app/.*: No such file or directory
==> Purging files for version 115.0.5759.0 of Cask google-chrome-canary
Error: Failure while executing; `/usr/bin/sudo -E -- /bin/cp -pR /opt/homebrew/Caskroom/google-chrome-canary/115.0.5759.0/Google\ Chrome\ Canary.app/\* /opt/homebrew/Caskroom/google-chrome-canary/115.0.5759.0/Google\ Chrome\ Canary.app/.\* /Applications/Google\ Chrome\ Canary.app/` exited with 1. Here's the output:
cp: /opt/homebrew/Caskroom/google-chrome-canary/115.0.5759.0/Google Chrome Canary.app/*: No such file or directory
cp: /opt/homebrew/Caskroom/google-chrome-canary/115.0.5759.0/Google Chrome Canary.app/.*: No such file or directory

0 replies

JBYoshi · 2023-05-11T01:32:24Z

JBYoshi
May 11, 2023

I'm able to consistently reproduce this using brew reinstall firefox. I'm currently trying to diagnose it.

3 replies

JBYoshi May 11, 2023

I haven't gotten the "undefined method: artifacts" error, but I've traced the "cp: [...].app/*: No such file or directory" error down to the wildcards in the cp command not being expanded.

JBYoshi May 11, 2023

Homebrew/brew#15407 is up to handle the wildcard problem.

fabianschulz May 11, 2023
Author

Thank you so much for digging into this @JBYoshi - really appreciate your help!

JBYoshi · 2023-05-12T15:25:48Z

JBYoshi
May 12, 2023

Someone else is reporting the same "undefined method: artifacts" error in Homebrew/brew#15406. I'm still not sure how to reproduce that specific error, so if you have some consistent steps to do that please let me know.

3 replies

JBYoshi May 12, 2023

I've tracked down the direct issue through some extra work with the type checker, and I'll submit a fix PR shortly once I add some unit tests for this case. However, the reason it wasn't caught earlier was because the relevant part of the code only runs as part of error handling recovery, which implies that there's another error going on too that's getting suppressed. Hopefully, once this particular error is fixed, we'll be able to track down the root cause.

JBYoshi May 12, 2023

Homebrew/brew#15412 has been submitted to fix the "undefined method: artifacts" error.

JBYoshi May 13, 2023

That PR has been merged, so that particular error should now be fixed.

fabianschulz · 2023-05-12T18:53:37Z

fabianschulz
May 12, 2023
Author

What I find strange is that I ran the exact same thing today (with the minor release of Firefox 113.0.1) and this time it went through without problems:

fabian@MacBook ~ % brew upgrade --greedy
==> Upgrading 1 outdated package:
firefox 113.0 -> 113.0.1
==> Upgrading firefox
==> Downloading https://raw.githubusercontent.com/Homebrew/homebrew-cask/(...)/Casks/firefox.rb
100.0%
==> Downloading https://download-installer.cdn.mozilla.net/pub/firefox/releases/113.0.1/mac/en-US/Firefox%20113.0.1.dmg
100.0%
==> Backing App 'Firefox.app' up to '/opt/homebrew/Caskroom/firefox/113.0/Firefox.app'
==> Removing App '/Applications/Firefox.app'
==> Unlinking Binary '/opt/homebrew/bin/firefox'
==> Moving App 'Firefox.app' to '/Applications/Firefox.app'
==> Linking Binary 'firefox.wrapper.sh' to '/opt/homebrew/bin/firefox'
==> Purging files for version 113.0 of Cask firefox
🍺 firefox was successfully upgraded!

Any idea why this time it worked as expected? AFAIK nothing was changed on Brew side or was committed since I reported the issue. I am curious if it was just me this time or if this issue still persists when upgrading other casks (such as Chrome, as mentioned by @timfallmk).

3 replies

SMillerDev May 13, 2023
Collaborator

See https://github.com/orgs/Homebrew/discussions/4498#discussioncomment-5891976, it was fixed

JBYoshi May 13, 2023

There hasn't been a stable release with these fixes yet, so unless you're in developer mode or following the latest commits, the fix won't have been rolled out yet.

fabianschulz May 14, 2023
Author

Thank you @JBYoshi & @SMillerDev for taking care of that bug. Much appreciated!

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Homebrew

Upgrading Firefox cask to v113 somehow corrupted the cask binary #4498

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 5 comments 12 replies

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

Select a reply

Upgrading Firefox cask to v113 somehow corrupted the cask binary #4498

Output of brew config

Output of brew doctor

Description of issue

Relevant casks

Replies: 5 comments · 12 replies

fabianschulz May 10, 2023 Author

fabianschulz May 10, 2023 Author

fabianschulz May 11, 2023 Author

fabianschulz May 12, 2023 Author

SMillerDev May 13, 2023 Collaborator

fabianschulz May 14, 2023 Author

Output of `brew config`

Output of `brew doctor`

Replies: 5 comments 12 replies

fabianschulz May 10, 2023
Author

fabianschulz May 10, 2023
Author

fabianschulz May 11, 2023
Author

fabianschulz
May 12, 2023
Author

SMillerDev May 13, 2023
Collaborator

fabianschulz May 14, 2023
Author