Improved pull request merge experience (public preview) feedback #143787
Replies: 751 comments 494 replies
-
Where is the "Merge without waiting for requirements to be met (bypass branch protections)" checkbox? |
Beta Was this translation helpful? Give feedback.
This comment was marked as spam.
This comment was marked as spam.
-
I like this feature so far, but the only transient bug I've seen is sometimes the checks show up fine while they are processing, but once all checks have passed, they all disappear. If you select the arrow to expand, it shows an empty list. I need to refresh the browser to see the passing checks. Again, just a small client-side issue that I'm seeing in Edge |
Beta Was this translation helpful? Give feedback.
-
The "view command line instructions" can be handy. It used to be a clickable element that extends to show CLI commands. It is not anymore. Could be good to add back in? |
Beta Was this translation helpful? Give feedback.
-
The new look on that PR successfully merged message confused me. Its appearance is quite similar to the message of you can click this button to delete the branch on the classic pane. This look makes me wonder if the auto delete branch feature is broken. |
Beta Was this translation helpful? Give feedback.
-
The "Delete branch" button CSS/style sometimes doesn't load. |
Beta Was this translation helpful? Give feedback.
-
Here is the new experience on a PR with an approval from a reviewer without write access, that has also passed all CI: Displaying red around this feels a bit odd to me. My first thought when I see it is that CI has failed, changes have been requested, or maybe that there are required approvals/checks still being waited on? (None of these are the case in this repository, which is nixpkgs) In comparison, the classic merge experience has a green accent: (I also noticed the new experience shows the approval of the reviewer w/o write access. This is an awesome addition for nixpkgs, so thanks!) The use of green lets a PR author or committer know at a glance that it should be good to merge. I'd much rather keep this behavior :) |
Beta Was this translation helpful? Give feedback.
-
Very good |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
it's buggy and requires a page refresh before the merge button works even when all the checks are already passing, overall it feels less real time than before |
Beta Was this translation helpful? Give feedback.
-
Sorry for the oversized screenshot! I noticed the text merge is not an allowed merge method in this repository in a repository I don't control - I'm assuming this isn't intended and so reporting it here. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
THANK YOU 🙇🏻♂️ ❤️ 🥳 ! |
Beta Was this translation helpful? Give feedback.
-
The sorting is braking. little bit when using matrix with numbers. |
Beta Was this translation helpful? Give feedback.
-
Recommendation, I will like to see the successful checks. It should not be collapsed by default. |
Beta Was this translation helpful? Give feedback.
-
Minor UI issue in Safari (and not Chrome at least) with auto-merge enabled. It seems the culprit is a missing |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Sitting on the page waiting for status checks to pass, the button does not switch away from "enable automerge" when the PR can be merged. |
Beta Was this translation helpful? Give feedback.
-
It would be great to have the whole CI item row clickable, not just the title. |
Beta Was this translation helpful? Give feedback.
-
One thing I like about the classic merge is that the the button to confirm the merge appears in the same position as the button to initiate the merge. In the new experience, the button is further down and is just a little bit less ergonomic. It does scroll into view which is nice but I prefer the classic experience. |
Beta Was this translation helpful? Give feedback.
-
Love this update. Somewhat similar to the other recommendations, I think having github remember your collapse preference for successful and skipped checks could be useful. |
Beta Was this translation helpful? Give feedback.
-
Neutral checks aren't immediately useful. Move them to the bottom. Move the successful/failing checks above neutral checks so they are easily accessible. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
The old UI elements used stable style/ID values. This was useful for user CSS scripts. The new UI elements don't have any stable styles/IDs: <label for=":r14:" class="InputLabel__StyledLabel-sc-l3hcqt-1 dMMsrG">Commit message</label>
<span class="TextInputWrapper__StyledTextInputBaseWrapper-sc-1mqhpbi-0 hmaawo" data-block="true"><textarea aria-invalid="false" rows="7" cols="30" class="Textarea__StyledTextarea-sc-1lf8it-0 hAxfsE" id=":r14:" aria-describedby="">...</textarea></span> There are tons of customizations for GitHub.com that rely on stable styles/IDs. For example, the standard GitHub commit message UI uses a variable width font, which makes it hard to format a commit message according to Git's 72 column convention. I use a CSS customization to fix that: https://userstyles.world/style/3474/github-commit-message-column-marker. With the new UI, I'm not sure that's possible anymore. |
Beta Was this translation helpful? Give feedback.
-
I would love to see a "Comment and Resolve Conversation" button for code reviews. Overall super good work though, happy to see prs getting some love. |
Beta Was this translation helpful? Give feedback.
-
The "delete head branch" after merging does not seem to be working reliably. Even though I have it enabled, the branch was not deleted: Screencast.from.2025-01-18.08-12-18.webm |
Beta Was this translation helpful? Give feedback.
-
It's a massive improvement, the best thing since Actions have been added to GitHub and I hope Actions UX will get the same kind of love next. Love how everything is now grouped by status, no need to scroll down the entire list to figure out what is failing. Would love to wish it to be either larger/make the size configurable because it's still small. Or ditch the scrollbar and have the pager go bigger or smaller depending on what you open. |
Beta Was this translation helpful? Give feedback.
-
In the old experience, there is a link to view the rules blocking a merge. In the new experience, no such link exists. That's too bad. |
Beta Was this translation helpful? Give feedback.
-
Important
Thanks ❤️ and happy previewing!
About the new experience
To help you better understand the state of your pull request and get it merged faster, the merge experience on the pull request page has been improved! This experience is currently in public preview.
What's new
We've maintained the familiar look of the existing merge experience while incorporating several usability improvements:
Try it out
Once available, you will see a Try the new merge experience link below the merge box on the pull request page:
Click it to switch to the improved experience. A link is also available for easily switching back to the existing experience. You can also toggle the experience via the feature preview dialog.
🔴 🔴 🔴 Known issues 🔴 🔴 🔴
You will run into some bugs and missing features (let us know when you do if not listed here).
Missing features
Features currently missing, but are coming:
Add your review
action in the Reviewers section (workaround: navigate to the Files Changed tab and clickReview changes
)Bugs
Resolve conflicts
button results in a 404/Not Found in certain casesThe base branch does not accept merge commits.
Recently fixed
Delete branch
button is sometimes missing (fixed by reloading the page)Delete branch
/Restore branch
fails with aCouldn't update branch
message (likely occurs only in PRs from forks)Restore branch
button is easily confused forDelete branch
(we moved theRestore branch
button out of the new merge experience so the only button that will appear here isDelete branch
)button (to enable auto-merge) is too easily confused for
Squash and merge` (to directly merge) because of similar text and styling *FIX IN PROGRESSLooking for feedback 🔈 🔈
Feedback
We want to hear from you! Post your comments, questions, likes, and dislikes below.
Beta Was this translation helpful? Give feedback.
All reactions