-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the bump version rules configurable #447
Labels
Comments
Any news or opinion on that one? We would be interested as well... |
Hello! I think it would be nice to have this, @jsurkont are you still interested in creating a PR? |
Hello @orhun! Yes, I still am. I'll create a PR soon. |
jsurkont
added a commit
to jsurkont/git-cliff
that referenced
this issue
Mar 4, 2024
jsurkont
added a commit
to jsurkont/git-cliff
that referenced
this issue
Mar 4, 2024
12 tasks
jsurkont
added a commit
to jsurkont/git-cliff
that referenced
this issue
Mar 4, 2024
jsurkont
added a commit
to jsurkont/git-cliff
that referenced
this issue
Mar 6, 2024
jsurkont
added a commit
to jsurkont/git-cliff
that referenced
this issue
Mar 11, 2024
orhun
added a commit
that referenced
this issue
Mar 11, 2024
closes #447 Co-authored-by: Orhun Parmaksız <[email protected]>
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
The new
bump
flag is great! However, since 4eef684 the default behavior for zero-based releases is problematic, i.e. features always bump the minor version, while breaking changes bump the major version, including from 0 to 1. I think this is an undesired behavior for projects following the bump rules described in next_version.Describe the solution you'd like
I think it should be possible to opt out from the default behavior. That is, the hardcoded values in
git-cliff/git-cliff-core/src/release.rs
Lines 117 to 118 in 4eef684
should take values form the configuration instead.
Describe alternatives you've considered
I couldn't think of any alternative (other than forking the project).
Additional context
If you would be interested, I could write a PR for it.
The text was updated successfully, but these errors were encountered: