Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the bump version rules configurable #447

Closed
jsurkont opened this issue Jan 15, 2024 · 3 comments · Fixed by #530
Closed

Make the bump version rules configurable #447

jsurkont opened this issue Jan 15, 2024 · 3 comments · Fixed by #530
Assignees
Labels
feature/request New feature or request good first issue Good for newcomers

Comments

@jsurkont
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The new bump flag is great! However, since 4eef684 the default behavior for zero-based releases is problematic, i.e. features always bump the minor version, while breaking changes bump the major version, including from 0 to 1. I think this is an undesired behavior for projects following the bump rules described in next_version.

Describe the solution you'd like

I think it should be possible to opt out from the default behavior. That is, the hardcoded values in

.with_features_always_increment_minor(true)
.with_breaking_always_increment_major(true)

should take values form the configuration instead.

Describe alternatives you've considered

I couldn't think of any alternative (other than forking the project).

Additional context

If you would be interested, I could write a PR for it.

@jsurkont jsurkont added the feature/request New feature or request label Jan 15, 2024
@ribeaud
Copy link

ribeaud commented Mar 1, 2024

Any news or opinion on that one? We would be interested as well...

@orhun
Copy link
Owner

orhun commented Mar 1, 2024

Hello! I think it would be nice to have this, @jsurkont are you still interested in creating a PR?

@orhun orhun removed their assignment Mar 1, 2024
@orhun orhun added the good first issue Good for newcomers label Mar 1, 2024
@jsurkont
Copy link
Contributor Author

jsurkont commented Mar 4, 2024

Hello @orhun! Yes, I still am. I'll create a PR soon.

jsurkont added a commit to jsurkont/git-cliff that referenced this issue Mar 4, 2024
jsurkont added a commit to jsurkont/git-cliff that referenced this issue Mar 4, 2024
jsurkont added a commit to jsurkont/git-cliff that referenced this issue Mar 4, 2024
jsurkont added a commit to jsurkont/git-cliff that referenced this issue Mar 6, 2024
jsurkont added a commit to jsurkont/git-cliff that referenced this issue Mar 11, 2024
orhun added a commit that referenced this issue Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/request New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants