Refactor for some fantasy-land stuff #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids tediously providing them, avoids typos, and properly categorises them with meta:magical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the work on #37, and addressing #39, this patch moves the Fantasy Land interface to aliases of the actual methods in Folktale structures. The new
provide-fantasy-land-aliasesmodule takes care of handling the aliases automatically, so this allows us to diverge our public API from Fantasy Land interfaces as well (avoiding issues like this recent PR fantasyland/fantasy-land#145), as long as we can map it to the interfaces. It also allows us to choose better names (e.g.:.apply()instead of.ap()).Closes #39.