[PSR-2 Compliance] Fix magento#8612: Hundreds of PHPCS-based static t…

…ests violations in mainline - apply manual fixes to make PHPCS happy, changes for "Constants are not allowed as the first argument of translation function, use string literal instead" - third-party constants are simply ignored, not sure if this is correct or not
orlangur · Feb 26, 2017 · 0dcab3b · 0dcab3b
1 parent 60d8cf0
commit 0dcab3b
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 1 deletion.
diff --git a/app/code/Magento/Braintree/Ui/Component/Report/Listing/Column/PaymentType.php b/app/code/Magento/Braintree/Ui/Component/Report/Listing/Column/PaymentType.php
@@ -43,6 +43,7 @@ public function toOptionArray()
      */
     private function getAvailablePaymentTypes()
     {
+        // @codingStandardsIgnoreStart
         return [
             PaymentInstrumentType::PAYPAL_ACCOUNT => __(PaymentInstrumentType::PAYPAL_ACCOUNT),
             PaymentInstrumentType::COINBASE_ACCOUNT => __(PaymentInstrumentType::COINBASE_ACCOUNT),
@@ -51,5 +52,6 @@ private function getAvailablePaymentTypes()
             PaymentInstrumentType::APPLE_PAY_CARD => __(PaymentInstrumentType::APPLE_PAY_CARD),
             PaymentInstrumentType::ANDROID_PAY_CARD => __(PaymentInstrumentType::ANDROID_PAY_CARD)
         ];
+        // @codingStandardsIgnoreEnd
     }
 }
diff --git a/app/code/Magento/Braintree/Ui/Component/Report/Listing/Column/Status.php b/app/code/Magento/Braintree/Ui/Component/Report/Listing/Column/Status.php
@@ -43,6 +43,7 @@ public function toOptionArray()
      */
     private function getAvailableStatuses()
     {
+        // @codingStandardsIgnoreStart
         return [
             Transaction::AUTHORIZATION_EXPIRED => __(Transaction::AUTHORIZATION_EXPIRED),
             Transaction::AUTHORIZING => __(Transaction::AUTHORIZING),
@@ -59,5 +60,6 @@ private function getAvailableStatuses()
             Transaction::SETTLEMENT_PENDING => __(Transaction::SETTLEMENT_PENDING),
             Transaction::SETTLEMENT_CONFIRMED => __(Transaction::SETTLEMENT_CONFIRMED)
         ];
+        // @codingStandardsIgnoreEnd
     }
 }
diff --git a/app/code/Magento/Braintree/Ui/Component/Report/Listing/Column/TransactionType.php b/app/code/Magento/Braintree/Ui/Component/Report/Listing/Column/TransactionType.php
@@ -43,9 +43,11 @@ public function toOptionArray()
      */
     private function getAvailableTransactionTypes()
     {
+        // @codingStandardsIgnoreStart
         return [
             Transaction::SALE => __(Transaction::SALE),
             Transaction::CREDIT => __(Transaction::CREDIT)
         ];
+        // @codingStandardsIgnoreEnd
     }
 }
diff --git a/app/code/Magento/Webapi/Controller/Rest/RequestValidator.php b/app/code/Magento/Webapi/Controller/Rest/RequestValidator.php
@@ -86,7 +86,7 @@ private function checkPermissions()
         if (!$this->authorization->isAllowed($route->getAclResources())) {
             $params = ['resources' => implode(', ', $route->getAclResources())];
             throw new AuthorizationException(
-                __(AuthorizationException::NOT_AUTHORIZED, $params)
+                __('Consumer is not authorized to access %resources', $params)
             );
         }
     }