2018 edition

[WildCryptoFox]

No description provided.

[orlp]

Doesn't compile with --features serde on the beta branch.

error[E0432]: unresolved import `SecondaryMap`                                                                                                                                                                                                                                 
   --> src/sparse_secondary.rs:813:9                                                                                                                                                                                                                                           
    |                                                                                                                                                                                                                                                                          
813 |     use SecondaryMap;                                                                                                                                                                                                                                                    
    |         ^^^^^^^^^^^^ no `SecondaryMap` external crate

In general, everything needs to be tested a bunch of times. On stable (or beta until 1.31 hits):

• default
• --features serde

Then on nightly:

• default
• --features serde
• --features unstable
• --features serde,unstable

I suppose this is only going to get worse when testing without std (having to test 8 times). It's the unfortunate reality of conditional compilation.

[WildCryptoFox]

@orlp I've only tested nightly with --no-default-features (no std), --features std (default), and --features unstable. Forgot about serde. Pushed patches for serde.

Edit: Though this exact branch doesn't have the no-std features. I only use nightly. std and std+serde should work on stable. If the latest patches are insufficient, I'll install a version per your request.

[WildCryptoFox]

@orlp Actually... nightly already fails to compile serde with your master due to unused macro import.

[orlp]

Oops. That's a bit weird though, since we do use the macros, just with use export now...

So do we just delete the #[macro_use]?

[WildCryptoFox]

@orlp Yes.

[orlp]

One down!