ci: Fix warnings

ornladios · Feb 24, 2022 · b51b731 · b51b731
1 parent 713dab0
commit b51b731
Show file tree

Hide file tree

Showing 20 changed files with 29 additions and 24 deletions.
diff --git a/CTestCustom.cmake.in b/CTestCustom.cmake.in
@@ -17,6 +17,8 @@ list(APPEND CTEST_CUSTOM_WARNING_EXCEPTION
   "Warning: Rank mismatch between actual argument.*"
   "zfp/types.h.*typedef"
   "was built for newer macOS version"
+  "warning generated"
+  "warnings generated"
 )
 list(APPEND CTEST_CUSTOM_COVERAGE_EXCLUDE
   ".*/thirdparty/.*"

diff --git a/examples/hello/bpFWriteCRead/CppReader.cpp b/examples/hello/bpFWriteCRead/CppReader.cpp
@@ -35,7 +35,7 @@ int main(int argc, char *argv[])
         const std::map<std::string, adios2::Params> variables =
             bpIO.AvailableVariables();
 
-        for (const auto variablePair : variables)
+        for (const auto &variablePair : variables)
         {
             std::cout << "Name: " << variablePair.first;
 

diff --git a/examples/hello/bpReader/helloBPReader.cpp b/examples/hello/bpReader/helloBPReader.cpp
@@ -41,7 +41,7 @@ int main(int argc, char *argv[])
         const std::map<std::string, adios2::Params> variables =
             bpIO.AvailableVariables();
 
-        for (const auto variablePair : variables)
+        for (const auto &variablePair : variables)
         {
             std::cout << "Name: " << variablePair.first;
 

diff --git a/source/adios2/core/Attribute.tcc b/source/adios2/core/Attribute.tcc
@@ -34,7 +34,7 @@ struct Pad;
 template <typename T, typename Enable>
 struct Pad
 {
-    static void Zero(T &arg) {}
+    static void Zero(T & /*arg*/) {}
 };
 
 template <typename T>

diff --git a/source/adios2/core/IO.cpp b/source/adios2/core/IO.cpp
@@ -143,6 +143,7 @@ std::unordered_map<std::string, IO::EngineFactoryEntry>::const_iterator
 FactoryLookup(std::string const &name)
 {
     std::lock_guard<std::mutex> factoryGuard(FactoryMutex);
+    (void)factoryGuard;
     return Factory.find(name);
 }
 

diff --git a/source/adios2/core/VariableBase.cpp b/source/adios2/core/VariableBase.cpp
@@ -54,9 +54,9 @@ bool VariableBase::IsCUDAPointer(void *ptr)
     cudaPointerAttributes attr;
     cudaPointerGetAttributes(&attr, ptr);
     return attr.type == cudaMemoryTypeDevice;
-#endif
-
+#else
     return false;
+#endif
 }
 
 size_t VariableBase::TotalSize() const noexcept

diff --git a/source/adios2/engine/bp5/BP5Writer_TwoLevelShm.cpp b/source/adios2/engine/bp5/BP5Writer_TwoLevelShm.cpp
@@ -196,7 +196,7 @@ void BP5Writer::SendDataToAggregator(format::BufferV *Data)
     std::vector<core::iovec> DataVec = Data->DataVec();
     size_t nBlocks = DataVec.size();
 
-    size_t sent = 0;
+    // size_t sent = 0;
     size_t block = 0;
     size_t temp_offset = 0;
     while (block < nBlocks)
@@ -241,7 +241,7 @@ void BP5Writer::SendDataToAggregator(format::BufferV *Data)
                 break;
             }
         }
-        sent += b->actual_size;
+        // sent += b->actual_size;
 
         /*if (m_RankMPI >= 42)
         {

diff --git a/source/adios2/engine/bp5/BP5Writer_TwoLevelShm_Async.cpp b/source/adios2/engine/bp5/BP5Writer_TwoLevelShm_Async.cpp
@@ -81,7 +81,7 @@ void BP5Writer::AsyncWriteThread_TwoLevelShm_SendDataToAggregator(
     std::vector<core::iovec> DataVec = Data->DataVec();
     size_t nBlocks = DataVec.size();
 
-    size_t sent = 0;
+    // size_t sent = 0;
     size_t block = 0;
     size_t temp_offset = 0;
     while (block < nBlocks)
@@ -126,7 +126,7 @@ void BP5Writer::AsyncWriteThread_TwoLevelShm_SendDataToAggregator(
                 break;
             }
         }
-        sent += b->actual_size;
+        // sent += b->actual_size;
         a->UnlockProducerBuffer();
     }
 }

diff --git a/source/adios2/engine/ssc/SscReader.cpp b/source/adios2/engine/ssc/SscReader.cpp
@@ -448,7 +448,7 @@ void SscReader::CalculatePosition(ssc::BlockVecVec &bvv,
     for (int rank = 0; rank < static_cast<int>(bvv.size()); ++rank)
     {
         bool hasOverlap = false;
-        for (const auto r : allRanks)
+        for (const auto &r : allRanks)
         {
             if (r.first == rank)
             {

diff --git a/source/adios2/engine/ssc/SscWriter.cpp b/source/adios2/engine/ssc/SscWriter.cpp
@@ -290,7 +290,7 @@ void SscWriter::CalculatePosition(ssc::BlockVecVec &writerVecVec,
         for (int rank = 0; rank < static_cast<int>(writerVecVec.size()); ++rank)
         {
             bool hasOverlap = false;
-            for (const auto r : currentReaderOverlapWriterRanks)
+            for (const auto &r : currentReaderOverlapWriterRanks)
             {
                 if (r.first == rank)
                 {

diff --git a/source/adios2/helper/adiosMemory.cpp b/source/adios2/helper/adiosMemory.cpp
@@ -50,6 +50,8 @@ void CopyPayloadStride(const char *src, const size_t payloadStride, char *dest,
         std::copy(src, src + payloadStride, dest);
     }
 #else
+    (void)endianReverse;
+    (void)destType;
     std::copy(src, src + payloadStride, dest);
 #endif
 }

diff --git a/source/adios2/operator/compress/CompressSZ.cpp b/source/adios2/operator/compress/CompressSZ.cpp
@@ -368,7 +368,7 @@ size_t CompressSZ::DecompressV1(const char *bufferIn, const size_t sizeIn,
 
     // Get type info
     int dtype = 0;
-    size_t dataTypeSize;
+    size_t dataTypeSize = 0;
     if (type == helper::GetDataType<double>() ||
         type == helper::GetDataType<std::complex<double>>())
     {
@@ -437,7 +437,7 @@ size_t CompressSZ::DecompressV2(const char *bufferIn, const size_t sizeIn,
 
     // Get type info
     int dtype = 0;
-    size_t dataTypeSize;
+    size_t dataTypeSize = 0;
     if (type == helper::GetDataType<double>() ||
         type == helper::GetDataType<std::complex<double>>())
     {

diff --git a/source/adios2/toolkit/format/bp5/BP5Serializer.cpp b/source/adios2/toolkit/format/bp5/BP5Serializer.cpp
@@ -583,7 +583,6 @@ static void GetMinMax(const void *Data, size_t ElemCount, const DataType Type,
     else if (MemSpace == MemorySpace::CUDA &&                                  \
              Type == helper::GetDataType<T>())                                 \
     {                                                                          \
-        const size_t size = ElemCount * sizeof(T);                             \
         const T *values = (const T *)Data;                                     \
         helper::CUDAMinMax(values, ElemCount, MinMax.MinUnion.field_##N,       \
                            MinMax.MaxUnion.field_##N);                         \

diff --git a/source/adios2/toolkit/sst/dp/rdma_dp.c b/source/adios2/toolkit/sst/dp/rdma_dp.c
@@ -115,7 +115,7 @@ static void init_fabric(struct fabric_state *fabric, struct _SstParams *Params,
                         CP_Services Svcs, void *CP_Stream)
 {
     struct fi_info *hints, *info, *originfo, *useinfo;
-    struct fi_av_attr av_attr = {0};
+    struct fi_av_attr av_attr = {FI_AV_UNSPEC};
     struct fi_cq_attr cq_attr = {0};
     char *ifname;
     int result;

diff --git a/source/utils/adios_iotest/adiosStream.cpp b/source/utils/adios_iotest/adiosStream.cpp
@@ -367,7 +367,7 @@ void adiosStream::writeADIOS(CommandWrite *cmdW, Config &cfg,
     MPI_Barrier(comm);
     timeStart = MPI_Wtime();
     engine.BeginStep();
-    for (const auto ov : cmdW->variables)
+    for (const auto &ov : cmdW->variables)
     {
         putADIOSArray(ov);
     }

diff --git a/source/utils/adios_iotest/adios_iotest.cpp b/source/utils/adios_iotest/adios_iotest.cpp
@@ -200,7 +200,7 @@ int main(int argc, char *argv[])
                 std::cout << "App " + std::to_string(settings.appId) + " Step "
                           << step << ": " << std::endl;
             }
-            for (const auto cmd : cfg.commands)
+            for (const auto &cmd : cfg.commands)
             {
                 if (!cmd->conditionalStream.empty() &&
                     cfg.condMap.at(cmd->conditionalStream) !=
@@ -248,8 +248,8 @@ int main(int argc, char *argv[])
                     auto cmdS = dynamic_cast<const CommandBusy *>(cmd.get());
                     std::chrono::high_resolution_clock::time_point start =
                         std::chrono::high_resolution_clock::now();
-                    auto sleeptime =
-                        std::chrono::microseconds(cmdS->busyTime_us);
+                    // auto sleeptime =
+                    //     std::chrono::microseconds(cmdS->busyTime_us);
                     if (!settings.myRank && settings.verbose)
                     {
                         double t =

diff --git a/source/utils/adios_iotest/processConfig.cpp b/source/utils/adios_iotest/processConfig.cpp
@@ -319,7 +319,7 @@ void printConfig(const Config &cfg)
     }
 
     std::cout << "    Commands :" << std::endl;
-    for (const auto cmd : cfg.commands)
+    for (const auto &cmd : cfg.commands)
     {
         if (!cmd->conditionalStream.empty())
         {
@@ -408,7 +408,7 @@ void printVarMaps(Config &cfg, std::string &groupName)
 
 void globalChecks(const Config &cfg, const Settings &settings)
 {
-    for (const auto cmd : cfg.commands)
+    for (const auto &cmd : cfg.commands)
     {
         if (!cmd->conditionalStream.empty())
         {

diff --git a/testing/adios2/engine/bp/TestBPWriteReadBlockInfo.cpp b/testing/adios2/engine/bp/TestBPWriteReadBlockInfo.cpp
@@ -55,6 +55,7 @@ void CheckStepsBlockInfo1D_C(adios2_variable *var, adios2_varinfo *vi,
                              const size_t NSteps, const size_t nproc,
                              const size_t Nx)
 {
+    (void)NSteps;
     EXPECT_EQ(vi->nblocks, nproc);
     adios2_shapeid shapeid;
     adios2_variable_shapeid(&shapeid, var);

diff --git a/testing/adios2/engine/staging-common/TestSupp.cmake b/testing/adios2/engine/staging-common/TestSupp.cmake
@@ -261,7 +261,7 @@ function(add_common_test basename engine)
     endif()
     set (timeout "${${basename}_TIMEOUT}")
     if ("${timeout}" STREQUAL "")
-       set (timeout "30")
+       set (timeout "60")
     endif()
 
     set_tests_properties(${testname} PROPERTIES

diff --git a/thirdparty/CMakeLists.txt b/thirdparty/CMakeLists.txt
@@ -1,10 +1,10 @@
 # Disable warnings in thirdparty code
 if(CMAKE_C_COMPILER_ID MATCHES
-    "^(GNU|Clang|AppleClang|XLClang|XL|VisualAge|SunPro|HP|Intel|PGI|NVIDIA)$")
+    "^(GNU|Clang|AppleClang|XLClang|XL|VisualAge|SunPro|HP|Intel|IntelLLVM|PGI|NVIDIA|NVHPC)$")
   set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -w")
 endif()
 if(CMAKE_CXX_COMPILER_ID MATCHES
-    "^(GNU|Clang|AppleClang|XLClang|XL|VisualAge|SunPro|HP|Intel|PGI|NVIDIA)$")
+    "^(GNU|Clang|AppleClang|XLClang|XL|VisualAge|SunPro|HP|Intel|IntelLLVM|PGI|NVIDIA|NVHPC)$")
   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -w")
 endif()