testing: Teach test helper functions to add both Serial and MPI tests #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test directory is only added when `ADIOS2_HAVE_MPI` is true. Drop explicit tests of that condition inside inside the directory.
The intermediate `NUM_TEST_PROCS` variable is not actually referenced anywhere that is not `if(ADIOS2_HAVE_MPI)`, so just use the original value from `MPIEXEC_MAX_NUMPROCS` directly. Quote it in property settings just in case it is somehow empty.
Avoid hard-coding test executable target names.
Avoid hard-coding test executable target names.
Teach `gtest_add_tests_helper` and `fortran_add_test_helper` to add both serial and MPI tests when possible. Update the `mpi` argument allowed enumeration values to distinguish the case of "mpi allowed" from "mpi only".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teach
gtest_add_tests_helperandfortran_add_test_helperto add both serial and MPI tests when possible. Update thempiargument allowed enumeration values to distinguish the case of "mpi allowed" from "mpi only". Update all call sites accordingly.With this, tests can run both serial and MPI variants when ADIOS2 is built with MPI enabled. Previously the tests would only run one or the other variant.