Process metadata really step-by-step in BP4 when StreamReader is on. … #2410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…So far, it was reading in metadata in chunks but it processed the whole chunk (multiple steps) at once. For true semantics, we want Variables and Attributes show up in their proper step and since the IO map holds all entries of all processed steps, the current processing can show variables in later steps too early. Now the chunks are kept in memory but only processed step by step.
|
Do not merge until Greg's attribute test is added with BP4 |
|
Well, merge it anyway, because that test cannot be modified for all engines but now it works as intended with StreamReader=ON |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…So far, it was reading in metadata in chunks but it processed the whole chunk (multiple steps) at once. For true semantics, we want Variables and Attributes show up in their proper step and since the IO map holds all entries of all processed steps, the current processing can show variables in later steps too early. Now the chunks are kept in memory but only processed step by step.