Address compile warnings across the project (Former: Enable -Wall) #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuckatkins
force-pushed
the
ci-wall
branch
2 times, most recently
from
1230ba5 to
0332af6
Compare
|
OK Chuck, I tried my best to remove the hdf5 related warnings and I also corrected those. in BP tests along the way. I will leave the rest to you. Especially the ones in the adiosMemory.inl. Looks like no one is using that function. |
chuckatkins
commented
Mar 12, 2021
There was a problem hiding this comment.
This is great @guj; Thank you! The rest of the errors seem to be outside the scope of HDF5 so I'll work through the rest.
germasch
reviewed
Mar 12, 2021
vicentebolea
force-pushed
the
ci-wall
branch
8 times, most recently
from
c29e222 to
9050522
Compare
vicentebolea
changed the title
- Add multiple EXPECT_THROW in tests - Corrects a integer overflow in InSituMPISchedules.cpp - Corrects a printf modifier in H5VolUtil.cpp - Enforce coding style across the project Co-authored-by: Chuck Atkins <[email protected]> Co-authored-by: Vicente Adolfo Bolea Sanchez <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address compile warnings across the project
Co-authored-by: Chuck Atkins [email protected]
Co-authored-by: Vicente Adolfo Bolea Sanchez [email protected]