Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destructor close #3278

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Destructor close #3278

merged 2 commits into from
Jul 12, 2022

Conversation

eisenhauer
Copy link
Member

No description provided.

… is called when the engine has not been shut down stafely with Close()
@eisenhauer
Copy link
Member Author

Addresses Issue #3274 by providing a place, DestructorClose(), where engines can place warnings or other shutdown activity in the event that the engine destructor gets called while the engine is still open. The engines modified here specifically do not generally call Close() in the engine destructor because that can be a heavy-weight call. Rather they're printing warnings or doing lighter-weight things that are less likely to cause problems. For some of the engines, like file reader BP3/4/5 file readers, DestructorClose() does nothing because the destructor cleans up pretty much everything on its own. Other engines were already calling their own Close() functions in the destructor. This PR doesn't change that if so. Some engines haven't been fully investigated, so DestructorClose() is simply an empty function which can be filled in when an appropriate action is determined.

@eisenhauer eisenhauer merged commit a1649b6 into ornladios:master Jul 12, 2022
@eisenhauer eisenhauer deleted the DestructorClose branch July 12, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants