-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build scripts for ADIOS2 with CUDA and Kokkos backend #3579
Build scripts for ADIOS2 with CUDA and Kokkos backend #3579
Conversation
I am not sure we need 5 scripts, a lot of the things are the same but I didn't know where to document how to build Kokkos and what modules to use for each system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anagainaru they look great! I am in favor of having those as a help to deploy in those systems.
We normally pass the shellcheck
script on shell scripts. Can you pass it and fix the potential warnings?
Maybe it is just ok for now, if we use those scripts more we can improve them iteratively |
I did not know about |
78773b2
to
2a3c47a
Compare
I fixed the warnings and the naming, I testing the new versions on Summit just to make sure I did not introduce some issues and it seems good. |
2a3c47a
to
3bf8c90
Compare
@anagainaru can you do a amend and repush, it seems that the CI did not start. Lets try our new shellcheck test :) |
@vicentebolea I tried shellcheck online and I did not get this warnings.
|
I think that shellcheck is all confused about -D KEY=VALUE type of argument, you can either do like "-DKEY=VALUE" or disable that specify check in that file. by adding |
For Summit, Perlmutter and Crusher