Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the memory space for Spans to Host #4343

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

anagainaru
Copy link
Contributor

Memory selections when GPU pointers are used for BP5 copies the data to internal buffers before min/max is applied. I am updating the memory space for spans to Host when data is moved to temp buffers.

Copy link
Member

@eisenhauer eisenhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the right fix...

@anagainaru anagainaru merged commit d975ac0 into ornladios:master Sep 11, 2024
37 of 38 checks passed
@anagainaru anagainaru deleted the gpuSpan branch September 11, 2024 13:00
@anagainaru anagainaru added this to the v2.10.2 milestone Oct 1, 2024
vicentebolea pushed a commit to vicentebolea/ADIOS2 that referenced this pull request Oct 23, 2024
Setting the memory space for Spans to Host

(cherry picked from commit d975ac0)
vicentebolea pushed a commit to vicentebolea/ADIOS2 that referenced this pull request Oct 23, 2024
Setting the memory space for Spans to Host

(cherry picked from commit d975ac0)
vicentebolea pushed a commit to vicentebolea/ADIOS2 that referenced this pull request Oct 23, 2024
Setting the memory space for Spans to Host

(cherry picked from commit d975ac0)
vicentebolea pushed a commit to vicentebolea/ADIOS2 that referenced this pull request Oct 23, 2024
Setting the memory space for Spans to Host

(cherry picked from commit d975ac0)
vicentebolea pushed a commit to vicentebolea/ADIOS2 that referenced this pull request Oct 24, 2024
Setting the memory space for Spans to Host

(cherry picked from commit d975ac0)
vicentebolea pushed a commit to vicentebolea/ADIOS2 that referenced this pull request Oct 24, 2024
Setting the memory space for Spans to Host

(cherry picked from commit d975ac0)
vicentebolea pushed a commit to vicentebolea/ADIOS2 that referenced this pull request Oct 24, 2024
Setting the memory space for Spans to Host

(cherry picked from commit d975ac0)
vicentebolea added a commit that referenced this pull request Oct 26, 2024
* release_210: (33 commits)
  Bump version to v2.10.2
  Merge pull request #4379 from vicentebolea/increace-cmake-version-dep-blosc
  Fix missing int64_t definition (#4365)
  Merge pull request #4346 from anagainaru/memSelLayout
  Merge pull request #4343 from anagainaru/gpuSpan
  Compress the lossless part of MGARD data with Zstd. It was uncompressed until now. (#4339)
  Fix an issue when reading blocks in streaming mode, when some producers did not write any block to output. (#4332)
  Fix in python API:  (#4331)
  Merge pull request #4303 from anagainaru/build-frontier
  Merge pull request #4293 from anagainaru/check_parser_lexer
  Derived variables of type StoreData should not record the expression string (#4247)
  Update ReadMe.md (#4243)
  Switch from ROCM_VERSION_MAJOR to HIP_VERSION_MAJOR (#4222)
  Merge pull request #4207 from anagainaru/hide-symbols
  Patch for when both xrootd and derived variables are activated (#4200)
  Add defines for BP3, BP4 and BP5 (#4191)
  Overload NdCopy instead of adding a new argument for the 2.10 release
  Revert "Backport #3759 to Release 2.10 branch. (cherry-picked from master branch #4340) (#4341)"
  Revert "Merge pull request #4189 from pnorbert/campaign-s3-support"
  ci,python: enable python win2022 serial build
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants