Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location names with two or more words not found unless adding symbol as separator #55

Closed
neilswann80 opened this issue Oct 5, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@neilswann80
Copy link

neilswann80 commented Oct 5, 2023

E.g. Port Talbot,Wales or South Cerney,England are not found.

Replacing the <space> with a symbol and they are found:
Port_Talbot,Wales
Port.Talbot,Wales
South+Cerney,England
South@Cerney,England

Need to do the same with countries also, e.g:
Cape_Town, South_Africa

Any symbol that's not a , or a <space> seems to work.

It should be easy enough to replace any space characters with underscores, maybe skipping/deleting one is if occurs directly after the ,
(but replace the space character(s) when writing the location on-screen so it looks nice 😄 )

@orontee orontee added the bug Something isn't working label Oct 5, 2023
@orontee orontee added this to the Winter 2023 version milestone Oct 5, 2023
@orontee
Copy link
Owner

orontee commented Oct 5, 2023

Shame on me! I forgot to "urlencode" the town and country names!

https://curl.se/libcurl/c/curl_easy_escape.html

@neilswann80
Copy link
Author

Shame on me! I forgot to "urlencode" the town and country names!

Sounds like you know of a better way of solving this... I'll have to read up on that method. 👍

orontee added a commit that referenced this issue Oct 6, 2023
@orontee orontee closed this as completed Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants